Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification result store/sync #6722

Merged
merged 6 commits into from
Apr 25, 2019
Merged

Conversation

dnsmichi
Copy link
Contributor

@dnsmichi dnsmichi commented Oct 24, 2018

Story

Every now and then notifications do not work, and the last resort is the executed command script. Instead of greps inside the icinga2.log, it would be nice to have the results available.

Having an HA enabled zone with two masters also renders this kind of complicated, as notifications run balanced similar to checkables. Some commands are logged on masterA, others on masterB. Synchronising the notification result between them allows us to keep track of it independently.

This also comes to mind with having one backend writer active, while the secondary is paused. Both need to synchronise the notification result event, and then one of them writes that to the backend (IDO won't receive that, just IcingaDB).

Solution

Instead of only logging the executed notification command line (notice level if ok, warning if failed), we want to have the command line available in memory for better analysis and debugging.

Furthermore, we'll need the command line via event available for Icinga DB and store the historical relevant parts next to the notified user, etc.

@dnsmichi
Copy link
Contributor Author

dnsmichi commented Dec 5, 2018

@Crunsher This might be relevant for IcingaDB.

@dnsmichi dnsmichi force-pushed the feature/notification-result branch from a51d9cf to 0611f3e Compare March 28, 2019 10:45
@dnsmichi dnsmichi changed the title WIP: Add notification result store/sync Add notification result store/sync Mar 28, 2019
@dnsmichi dnsmichi requested a review from lippserd March 28, 2019 12:29
@dnsmichi dnsmichi added enhancement New feature or request area/distributed Distributed monitoring (master, satellites, clients) area/notifications Notification events labels Mar 28, 2019
@dnsmichi dnsmichi added this to the 2.11.0 milestone Mar 30, 2019
@dnsmichi
Copy link
Contributor Author

I'll merge this now, and let everyone test the snapshot packages then.

@dnsmichi dnsmichi merged commit a630d01 into master Apr 25, 2019
@dnsmichi dnsmichi deleted the feature/notification-result branch April 25, 2019 13:56
@dnsmichi dnsmichi mentioned this pull request May 6, 2019
8 tasks
This was referenced Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/distributed Distributed monitoring (master, satellites, clients) area/notifications Notification events enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant