Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert NotificationResult #7737

Merged
merged 6 commits into from
Jan 9, 2020
Merged

Conversation

dnsmichi
Copy link
Contributor

@dnsmichi dnsmichi commented Jan 7, 2020

This reverts #6722

Existing cluster messages don't harm anything, since the nr parameter
simply is ignored for now.

@dnsmichi dnsmichi requested a review from lippserd January 7, 2020 13:34
@dnsmichi dnsmichi added area/distributed Distributed monitoring (master, satellites, clients) area/runtime Downtimes, comments, dependencies, events labels Jan 7, 2020
Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revert fixes the segfault mentioned in #7532 (comment)

@lippserd lippserd merged commit cb21086 into master Jan 9, 2020
@lippserd lippserd deleted the bugfix/revert-notification-result branch January 9, 2020 09:06
@lippserd lippserd added this to the 2.12.0 milestone Jan 9, 2020
@lazyfrosch lazyfrosch mentioned this pull request Jan 9, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/distributed Distributed monitoring (master, satellites, clients) area/runtime Downtimes, comments, dependencies, events
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants