fix velocity build #332
Merged
fix velocity build #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zml2008
force-pushed
the
fix/1.7.0/velocity-build
branch
from
8805a43
to
783f128
Compare
|
Could we just bump velocity api to 3.x instead? |
|
likely, but that would also technically be a breaking change, and likely bump |
|
It looks like velocity-api is currently compileOnly, so just bumping the version shouldn't make any difference for consumers. As far as the java version, we should just be able to disableAutoTargetJvm()? Excluding these dependencies works, but if we can I'd prefer to update to a supported version of velocity-api instead |
No source changes have been made, so this maintains compatibility with Velocity 1 for anyone who still uses it.
zml2008
force-pushed
the
fix/1.7.0/velocity-build
branch
from
783f128
to
df685cb
Compare
jpenilla
approved these changes
Jan 5, 2022
jpenilla
pushed a commit
that referenced
this pull request
Feb 28, 2022
jpenilla
pushed a commit
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.