feat(annotations): add @CommandMethod annotation processing
#366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Citymonstret
force-pushed
the
feature/1.7.0/compile-time-commandmethod-validation
branch
from
3b8c8fc
to
4eb57a9
Compare
Citymonstret
force-pushed
the
feature/1.7.0/compile-time-commandmethod-validation
branch
from
4eb57a9
to
99bc160
Compare
We now verify the following at compile time: - That `@CommandMethod` annotated methods are non-static (error) - That `@CommandMethod` annotated methods are public (warning) - That the `@CommandMethod` syntax and specified `@Argument`s match - That no optional argument precedes a required argument
Citymonstret
force-pushed
the
feature/1.7.0/compile-time-commandmethod-validation
branch
from
99bc160
to
8db995b
Compare
Citymonstret
deleted the
feature/1.7.0/compile-time-commandmethod-validation
branch
Citymonstret
added a commit
that referenced
this pull request
Jun 3, 2022
We now verify the following at compile time: - That `@CommandMethod` annotated methods are non-static (error) - That `@CommandMethod` annotated methods are public (warning) - That the `@CommandMethod` syntax and specified `@Argument`s match - That no optional argument precedes a required argument
jpenilla
pushed a commit
that referenced
this pull request
Jun 19, 2022
We now verify the following at compile time: - That `@CommandMethod` annotated methods are non-static (error) - That `@CommandMethod` annotated methods are public (warning) - That the `@CommandMethod` syntax and specified `@Argument`s match - That no optional argument precedes a required argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now verify the following at compile time:
@CommandMethodannotated methods are non-static (error)@CommandMethodannotated methods are public (warning)@CommandMethodsyntax and specified@Arguments match