Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use trusted publishing for pypi #1154

Merged
merged 1 commit into from
May 26, 2024
Merged

use trusted publishing for pypi #1154

merged 1 commit into from
May 26, 2024

Conversation

zsol
Copy link
Member

@zsol zsol commented May 26, 2024

Summary

This PR removes the hardcoded access token for pypi from the workflow.

Test Plan

Run publishing to test.pypi.org in a non-final version of this PR.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 26, 2024
@zsol zsol force-pushed the pypi-trusted-publishing branch from 4b846e3 to 6379a35 Compare May 26, 2024 15:47
Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.15%. Comparing base (96f5341) to head (e4592c0).

Current head e4592c0 differs from pull request most recent head 530ff10

Please upload reports for the commit 530ff10 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1154      +/-   ##
==========================================
- Coverage   91.16%   91.15%   -0.01%     
==========================================
  Files         262      261       -1     
  Lines       26842    26830      -12     
==========================================
- Hits        24470    24458      -12     
  Misses       2372     2372              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zsol zsol force-pushed the pypi-trusted-publishing branch 2 times, most recently from d2aaf93 to e4592c0 Compare May 26, 2024 17:04
@zsol zsol force-pushed the pypi-trusted-publishing branch from e4592c0 to 530ff10 Compare May 26, 2024 21:56
@zsol zsol marked this pull request as ready for review May 26, 2024 21:57
@zsol zsol merged commit 0b4016c into main May 26, 2024
21 checks passed
@zsol zsol deleted the pypi-trusted-publishing branch May 26, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants