Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming prior to registration #63

Open
maltezfaria opened this issue Jun 16, 2024 · 0 comments
Open

Renaming prior to registration #63

maltezfaria opened this issue Jun 16, 2024 · 0 comments

Comments

@maltezfaria
Copy link
Member

maltezfaria commented Jun 16, 2024

I think a few (or many, we will see) structures and functions could use a better name in Inti. I am opening this issue so that we can start collecting and discussing them. Once we agree, we can do a single "search and replace" to PR to fix the issues.

@caperezar and @tanderson92 feel free to edit this list. Here is what I have so far:

  • LagrangeMesh --> Mesh: poor choice since this mesh can support other types of elements (e.g. ParametricElement)
  • domain --> reference_shape: for a ReferenceInterpolant, the domain method is used to return its ReferenceShape. I think it would be more clear to rename it
  • Quadrature --> MeshQuadrature: I'm not so sure about this one, but our Quadrature structure is quite rich since it contains the mesh and metadata to index using domains
  • Compression methods --> acceleration methods?
  • AbstractPDE --> AbstractDifferentialOperator, and rename the keyword pde to operator in the various API methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant