-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] - estimateTransactionKeyWitnessCount
doesn't appear to consider native (simple) scripts
#551
Comments
cc: @Jimbo4350 |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days. |
Internal/External
External
Area
Transaction building
Summary
For transactions making use of native scripts, the required number of key witness may be more than what is returned by
estimateTransactionKeyWitnessCount
as it doesn't consider them (native scripts). Fwiw, the key witnesses required by native script are taken fromtransaction_witness_set
(see attached image from Shelley ledger specification) and thus the required signatories mentioned by these scripts need not have any mention intransaction_body
.Wrong estimate by
estimateTransactionKeyWitnessCount
leads to wrong estimate of required transaction fees when building the transaction usingcardano-api
'smakeTransactionBodyAutoBalance
unless one gives appropriate key witness estimate to it.The text was updated successfully, but these errors were encountered: