Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UnwitnessedCliFormattedTxBody constructor #690

Closed
smelc opened this issue Apr 4, 2024 · 1 comment · Fixed by #707
Closed

Remove UnwitnessedCliFormattedTxBody constructor #690

smelc opened this issue Apr 4, 2024 · 1 comment · Fixed by #707
Assignees
@smelc

Comments

@smelc
Copy link
Contributor

smelc commented Apr 4, 2024 •
edited
Loading

From @Jimbo4350, here on Slack:

In cardano-cli there is:

data IncompleteTx
  = UnwitnessedCliFormattedTxBody (InAnyShelleyBasedEra TxBody)
  | IncompleteCddlFormattedTx (InAnyShelleyBasedEra Tx)

We need to remove the UnwitnessedCliFormattedTxBody constructor because it's no longer possible to produce a "cli" formatted tx/txbody.

Be sure to check in with QA before merging that PR however (make sure they run their tests).
@smelc smelc self-assigned this Apr 4, 2024
@smelc smelc mentioned this issue Apr 9, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label May 5, 2024
@smelc smelc removed the Stale label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smelc smelc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove UnwitnessedCliFormattedTxBody constructor IntersectMBO/cardano-cli
1 participant
@smelc