-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow empty treasury withdrawals #4582
Comments
CC @WhatisRT and @williamdemeo I don't think we need to have a matching predicate check in the spec, but wanted to let you know that we are planning to implement a predicate failure like this. |
With these types of things I wonder if it'd be a good idea to implement some granularity for predicate failures. I.e. ones that affect block validation and ones that trigger when a node verifies individual transactions for the mempool, possibly functioning more like a warning. Then you could just add this to the next version without a HF. In general that would make it much easier to patch issues like that. You wouldn't get guarantees that these transactions don't exist, but that's not an issue for downstream tooling since it needs to handle the possibility of such situations in the era before they are fixed right now anyway. |
@WhatisRT I've opened a ticket for a potential solution like this: #4622 |
Currently a
TreasuryWithdrawal
action can contain an empty map, which would result in a proposal that does nothing. This does not have any dangerous implications, but it doesn't make sense to haveTreasuryWithdrawal
s that has no affect, especially since it has confused some developers in the past: IntersectMBO/cardano-cli#876We should add a predicate failure that prevents
TreasuryWithdrawal
s withMap
s that sum to0
ADA. This would not only prevent empty withdrawals, but also the ones that don't try to withdraw any funds.The text was updated successfully, but these errors were encountered: