Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TxBody cli intermediate format #4814

Closed
17 tasks
Jimbo4350 opened this issue Jan 19, 2023 · 2 comments
Closed
17 tasks

Remove TxBody cli intermediate format #4814

Jimbo4350 opened this issue Jan 19, 2023 · 2 comments
Assignees
Labels
Stale user type: internal Created by an IOG employee

Comments

@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Jan 19, 2023

What

Remove support for the TxBody intermediate format

Why

It is no longer possible to create TxBodys in the cli intermediate format since #4303. We should fully drop support as it is unlikely that users have unsigned transactions serialized in the intermediate tx body format lying around. Fully dropping support allows us to clean up the code in cardano-cli.

Personas

  • SPOs
  • dApp Devs
  • Exchanges
  • Wallets
  • 3rd party tools
  • ADA holders

Definition of Done (DoD)

  • Acceptance Criteria + User Stories & DoD created and singed-off (by PO, dev & test owners)
  • Builds successfully on CI
  • Code & Test review (as per Acceptance Criteria)
  • There is documentation and/or examples for the new functionality (usage/response)
  • Log/record changes on Vnext (or similar depending on what we adopt)
  • Ticket number(s) included in PR description
  • All Acceptance Criteria met and covered by dev/unit/property/integration tests
  • System/E2E automated tests + System Test Engineer Owner Sign-off

NOTE: Ideally, we should merge only fully implemented and tested features into the master branch.
So all the above steps are required for the PR to be merged.
In order to avoid the PRs becoming stale and requiring to be rebased on master, these can be merged
after a reasonable time (current agreement is 3 days) if the System Test Engineer Owner's sign-off
was not provided (last step in the DoD).

IMPORTANT: Any deviation from the plan should be discussed and agreed as a comment in the Feature file.

Sign-off

  • Product Owner
  • Dev Owner
  • System Test Engineer Owner

Related PRs

  1. PR Deprecate intermediate txbody format #4303

Acceptance Criteria

Acceptance Criteria & User Stories define here (or in a separate file (linked here) for a big feature)

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Feb 19, 2023
@Jimbo4350
Copy link
Contributor Author

Resolved by: IntersectMBO/cardano-api@e739675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale user type: internal Created by an IOG employee
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant