Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ChainSelStarvation carry an Enclosed #1349

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

jasagredo
Copy link
Contributor

The definition of this tracer, carrying a Time, was basically isomorphic to carrying an Enclosed.

Copy link
Contributor

@Niols Niols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note that the previous ChainSelStarvation* events carried a time. This was added the first time we saw very short starvations, got extremely, and wanted to be sure to measure their exact length, without potential delays introduced in the tracing system. After discussion with @jasagredo, we decided that it was most likely not necessary at this point; it can always be re-introduced subsequently. The time is of course still written in the starvationVar, because that is used by the BlockFetch logic.

@Niols
Copy link
Contributor

Niols commented Dec 19, 2024

(Impressive that you stumble about this time limited leashing attack bug again, considering how rare it is! It also makes one wonder how we didn't notice it beforehand.)

@Niols Niols added the Genesis PRs related to Genesis testing and implementation label Dec 19, 2024
@jasagredo jasagredo force-pushed the js/chain-sel-starvation branch from e1403a8 to 25002b0 Compare December 19, 2024 11:30
Copy link
Contributor

@nfrisby nfrisby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems fine, since it seems unlikely we'll truly need more than the centisecond precision the node's logging infrastructure gives on tracer times in the log.

I have no strong preference either way, but I haven't been the one debugging these error traces. So I'll defer to you and Niols.

@jasagredo jasagredo force-pushed the js/chain-sel-starvation branch from 25002b0 to 7e9a939 Compare December 26, 2024 10:43
@jasagredo jasagredo merged commit 9e001f7 into blockfetch/milestone-1 Dec 26, 2024
4 of 5 checks passed
@jasagredo jasagredo deleted the js/chain-sel-starvation branch December 26, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Genesis PRs related to Genesis testing and implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants