Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import config alert #273

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Fix import config alert #273

merged 3 commits into from
Aug 7, 2024

Conversation

IraSoro
Copy link
Owner

@IraSoro IraSoro commented Aug 7, 2024

Closed #270

I fixed this problem.
But it will work only if: you already have a dark theme, you import a config with a dark theme, the alert is displayed with a dark theme. But if you import a config with a light theme, the alert will be displayed with a dark theme this time.

The dark alert looks like this:
image

I also removed the word beta from the dark theme selection.

And changed icon for theme select. The new icon looks like this
image

@IraSoro IraSoro added this to the v2.4.2 milestone Aug 7, 2024
@IraSoro IraSoro self-assigned this Aug 7, 2024
@IraSoro IraSoro requested a review from imblowfish August 7, 2024 14:20
@IraSoro IraSoro marked this pull request as ready for review August 7, 2024 14:20
@IraSoro IraSoro merged commit f02568d into master Aug 7, 2024
1 check passed
@IraSoro IraSoro deleted the 270-fix-config-alert branch August 7, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Dark theme is not applied on config import alert
2 participants