Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External content #59

Merged
merged 3 commits into from
Apr 30, 2019
Merged

External content #59

merged 3 commits into from
Apr 30, 2019

Conversation

dannylamb
Copy link
Contributor

@dannylamb dannylamb commented Apr 16, 2019

GitHub Issue: Part of Islandora/documentation#1079

What's new?

  • Version bumps for fcrepo-camel-toolbox and fedora 5 compatibility
  • New islandora-indexing-fcrepo-file-external route for external content
  • Tests got updated

How should this be tested?

Islandora-Devops/islandora-playbook#100

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

@Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #59 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #59      +/-   ##
============================================
+ Coverage     84.71%   84.81%   +0.09%     
  Complexity       93       93              
============================================
  Files            16       16              
  Lines           314      316       +2     
  Branches          1        1              
============================================
+ Hits            266      268       +2     
  Misses           47       47              
  Partials          1        1
Impacted Files Coverage Δ Complexity Δ
...slandora/alpaca/indexing/fcrepo/FcrepoIndexer.java 90.47% <100%> (+0.23%) 6 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1561f04...8f3f02f. Read the comment docs.

@dannylamb dannylamb changed the title Bumping versions for 5.0.0 java client External content Apr 23, 2019
Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@seth-shaw-unlv seth-shaw-unlv merged commit ddebb2e into master Apr 30, 2019
@dannylamb dannylamb deleted the fix-triplestore-indexing branch June 3, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants