Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP notices from OpenSeadragon admin/display #1124

Closed
kayakr opened this issue May 20, 2019 · 2 comments
Closed

PHP notices from OpenSeadragon admin/display #1124

kayakr opened this issue May 20, 2019 · 2 comments

Comments

@kayakr
Copy link
Contributor

kayakr commented May 20, 2019

OpenSeadragon settings show numerous PHP notices, e.g. http://localhost:8000/admin/config/media/openseadragon

  • Notice: Undefined index: fit_to_aspect_ratio in Drupal\openseadragon\Form\OpenSeadragonSettingsForm->buildForm() (line 108 of modules/contrib/openseadragon/src/Form/OpenSeadragonSettingsForm.php).
  • Notice: Undefined index: compositeOperation in Drupal\openseadragon\Form\OpenSeadragonSettingsForm->buildForm() (line 180 of modules/contrib/openseadragon/src/Form/OpenSeadragonSettingsForm.php).
  • Notice: Undefined index: placeholderFillStyle in Drupal\openseadragon\Form\OpenSeadragonSettingsForm->buildForm() (line 215 of modules/contrib/openseadragon/src/Form/OpenSeadragonSettingsForm.php).
  • Notice: Undefined index: minZoomLevel in Drupal\openseadragon\Form\OpenSeadragonSettingsForm->buildForm() (line 231 of modules/contrib/openseadragon/src/Form/OpenSeadragonSettingsForm.php).
  • Notice: Undefined index: maxZoomLevel in Drupal\openseadragon\Form\OpenSeadragonSettingsForm->buildForm() (line 239 of modules/contrib/openseadragon/src/Form/OpenSeadragonSettingsForm.php).
  • Notice: Undefined index: navigatorTop in Drupal\openseadragon\Form\OpenSeadragonSettingsForm->buildForm() (line 698 of modules/contrib/openseadragon/src/Form/OpenSeadragonSettingsForm.php).
  • Notice: Undefined index: navigatorLeft in Drupal\openseadragon\Form\OpenSeadragonSettingsForm->buildForm() (line 706 of modules/contrib/openseadragon/src/Form/OpenSeadragonSettingsForm.php).
  • Notice: Undefined index: navigatorHeight in Drupal\openseadragon\Form\OpenSeadragonSettingsForm->buildForm() (line 714 of modules/contrib/openseadragon/src/Form/OpenSeadragonSettingsForm.php).
  • Notice: Undefined index: navigatorWidth in Drupal\openseadragon\Form\OpenSeadragonSettingsForm->buildForm() (line 722 of modules/contrib/openseadragon/src/Form/OpenSeadragonSettingsForm.php).
  • Notice: Undefined index: referenceStripHeight in Drupal\openseadragon\Form\OpenSeadragonSettingsForm->buildForm() (line 945 of modules/contrib/openseadragon/src/Form/OpenSeadragonSettingsForm.php).
  • Notice: Undefined index: referenceStripWidth in Drupal\openseadragon\Form\OpenSeadragonSettingsForm->buildForm() (line 953 of modules/contrib/openseadragon/src/Form/OpenSeadragonSettingsForm.php).

OpenSeadragon shows PHP notice:

  • Notice: Undefined index: fit_to_aspect_ratio in template_preprocess_openseadragon_formatter() (line 95 of modules/contrib/openseadragon/openseadragon.module).
@seth-shaw-unlv
Copy link
Contributor

All the ones I've looked at so far are due to missing defaults in openseadragon.settings. Two options: first, add an entry for each of them in the settings file, or second, check in the form code if it is set and provide a blank value if missing.

@whikloj
Copy link
Member

whikloj commented May 23, 2019

Resolved with Islandora/openseadragon@03610ed

@whikloj whikloj closed this as completed May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants