Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove triplestore client #69

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Apr 13, 2017

GitHub Issue: Resolves Islandora/documentation#600

What does this Pull Request do?

Removes Triplestore Client

How should this be tested?

TravisCI should cover it. Another set of eyes making sure I got everything is good too.

Interested parties

@Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented Apr 13, 2017

Codecov Report

Merging #69 into master will decrease coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #69      +/-   ##
===========================================
- Coverage     93.63%   93.2%   -0.44%     
+ Complexity       24      23       -1     
===========================================
  Files             3       2       -1     
  Lines           110     103       -7     
===========================================
- Hits            103      96       -7     
  Misses            7       7
Impacted Files Coverage Δ Complexity Δ
src/Chullo.php 91.52% <ø> (ø) 15 <0> (ø) ⬇️
src/FedoraApi.php 95.45% <ø> (ø) 8 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d198ca...2fc3419. Read the comment docs.

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for culling the PHP versions in the doc comments

@dannylamb dannylamb merged commit f59f935 into Islandora:master Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants