-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push "latest" tag #250
Comments
Some potential issues with |
As someone who uses ISLE-DC for local one-off testing, I think this would be awesome. |
The convention used else where on docker hub is not to prefix with |
Also we'll have a |
Sorted concurrency problems on push using https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency |
Done under #238 |
|
@misilot, brought up a good idea on Slack to add latest tags. https://islandora.slack.com/archives/CM6F4C4VA/p1665586667980639
So, tasks would be to:
Update existing tags such that they are prefixed with
v
, i.e.v1.0.7
. Do not remove the old tags though.Change release workflow to:
latest
tag.v#
.v#.#
.So, if the two tags 1.1.1 1.1.2, exist and a new 1.1.3 release is made it would create the following Docker tags on release.
v1.1.3
v1.1
(Replaces the existing v1.1, which would have been pointing to v1.1.2 previously)v1
(Replaces the existing v1, which would have been pointing to v1.1.2 previously)latest
N.B. Note that this does not create new tags in the Git repository, only tags for the Docker images produced, as it's not considered good practice to have Git tags that change which commit they point too.
Change push workflow to check if it is on the main branch, and the latest commit, in the main branch. In which case it should always push to
latest-dev
The text was updated successfully, but these errors were encountered: