Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 307 - Adding xms and xmx for Cantaloupe heap #310

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

g7morris
Copy link
Contributor

Per #307

Copy link
Contributor

@noahwsmith noahwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this in our base project, the variables do what we want and things work pretty well. I snuck in adding a missing library libjpeg-turbo.

@g7morris
Copy link
Contributor Author

g7morris commented Nov 30, 2023

@noahwsmith Awesome! Do note, this change will require downstream isle-dc users to add these two new variables, Im guessing either in the docker-compose.yml file or the .env file. I'll work on crafting a PR to that effect once these changes are approved and merged.

@noahwsmith
Copy link
Contributor

You've set default values so it technically doesn't require a change, but folks should know that the defaults have been set and how to change them, for sure.

Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this in isle-dc. I pulled in the 307-set-heap-sizes-for-java-in-cantaloupe images and ran ps aux | grep java in the cantaloupe container which displayed the default values for xms and xmx. I then used the xms and xmx variables in my docker compose file but set the values a different amount than the default values. I restarted the containers and I ran the same command as before and it displayed the values from my docker compose file.

@aOelschlager aOelschlager merged commit 13ae1df into main Nov 30, 2023
76 checks passed
@nigelgbanks nigelgbanks deleted the 307-set-heap-sizes-for-java-in-cantaloupe branch December 1, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It would be really nice to be able to set Heap sizes for Java in Cantaloupe
3 participants