-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 307 - Adding xms and xmx for Cantaloupe heap #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this in our base project, the variables do what we want and things work pretty well. I snuck in adding a missing library libjpeg-turbo
.
@noahwsmith Awesome! Do note, this change will require downstream isle-dc users to add these two new variables, Im guessing either in the docker-compose.yml file or the |
You've set default values so it technically doesn't require a change, but folks should know that the defaults have been set and how to change them, for sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this in isle-dc. I pulled in the 307-set-heap-sizes-for-java-in-cantaloupe images and ran ps aux | grep java
in the cantaloupe container which displayed the default values for xms and xmx. I then used the xms and xmx variables in my docker compose file but set the values a different amount than the default values. I restarted the containers and I ran the same command as before and it displayed the values from my docker compose file.
Per #307