Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should secrets be stored in the "codebase" directory? #249

Closed
misilot opened this issue Apr 8, 2022 · 2 comments
Closed

Should secrets be stored in the "codebase" directory? #249

misilot opened this issue Apr 8, 2022 · 2 comments

Comments

@misilot
Copy link
Contributor

misilot commented Apr 8, 2022

Since if you were to try and restore a system using your codebase directory and isle-dc will depend on values in the "secrets" folder being restored retained (druapl database credentials at least)?

And will run into a chicken and egg of the secrets don't exist when trying to create a new system with an existing codebase.

Just food for though.
@misilot
Copy link
Contributor Author

misilot commented Apr 8, 2022

Maybe not, #226 may solve my concerns I was running into.

@misilot
Copy link
Contributor Author

misilot commented Apr 26, 2022

Looks like https://github.com/Islandora-Devops/isle-buildkit/blob/main/drupal/rootfs/etc/islandora/utilities.sh#L341-L400 should address this? So, I will close this.

@misilot misilot closed this as completed Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@misilot