Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make production #350

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

joshdentremont
Copy link
Contributor

added commands to create drupal database and modify settings.php before running drush site install

added commands to create drupal database and modify settings.php before running drush site install
@aOelschlager aOelschlager self-requested a review July 12, 2023 17:34
@joshdentremont
Copy link
Contributor Author

Before I added this line, make production was failing with:

docker compose exec -T drupal with-contenv bash -lc "drush si -y --existing-config minimal --account-pass 'XCIs6LUzks1MFwwU2WlFs1KDiOpz1gCsiDtNr8aAAqBQ9mjV'"

 You are about to:
 * Create a sites/default/settings.php file
 * CREATE the 'drupal' database.

 // Do you want to continue?: yes.

 [warning] Failed to drop or create the database. Do it yourself before installing. ERROR 2002 (HY000): Can't connect to server on '127.0.0.1' (115)


In SiteInstallCommands.php line 88:

  Existing config directory  not found

So I think it couldn't find the config/sync directory because it was not being specified in settings.php.

For testing you should be able to run make production without this PR and it should throw a similar error. With this PR it should create the site successfully.

Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested following the instructions for installing a production server and it worked.

@aOelschlager aOelschlager merged commit 37cb8e7 into Islandora-Devops:development Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants