-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update traefik version #359
Update traefik version #359
Conversation
updated version of Traefik to match the version that site template uses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too
Quick question of why aren't we attempting to use the latest version of traefik of 2.10.4 ? Did someone test and that didn't work? Or does this traefik value in the isle-site-template also need to be upgraded first and then this project? Just curious what the order of ops is here? Should we work with @nigelgbanks on this too? |
Just an FYI, tested running with latest |
@g7morris That's a good question. I just used the same one as the site template because I figured that was what was tested with Buildkit. I would be happy to bump it up, but I think we should probably keep Isle and Site Template on the same version, so we should bump both at the same time. |
No need to sync with |
update traefik to latest version
Updated this to use the newest version, 2.10.5 |
updated version of Traefik to match the version that site template uses.