Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update traefik version #359

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

joshdentremont
Copy link
Contributor

updated version of Traefik to match the version that site template uses.

updated version of Traefik to match the version that site template uses.
Copy link
Contributor

@joecorall joecorall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@DonRichards DonRichards self-requested a review October 4, 2023 17:27
@g7morris
Copy link
Collaborator

g7morris commented Oct 5, 2023

Quick question of why aren't we attempting to use the latest version of traefik of 2.10.4 ? Did someone test and that didn't work?

Or does this traefik value in the isle-site-template also need to be upgraded first and then this project?

Just curious what the order of ops is here?

Should we work with @nigelgbanks on this too?

@g7morris
Copy link
Collaborator

g7morris commented Oct 5, 2023

Just an FYI, tested running with latest 2.10.4 on an existing site with no ill effects. More extensive testing warranted.

@joshdentremont
Copy link
Contributor Author

@g7morris That's a good question. I just used the same one as the site template because I figured that was what was tested with Buildkit.

I would be happy to bump it up, but I think we should probably keep Isle and Site Template on the same version, so we should bump both at the same time.

@nigelgbanks
Copy link
Contributor

No need to sync with isle-site-template. The version used in the site template was just the latest available at the time it was written, I think. There isn't any real need to test with isle-buildkit releases, either. The only concern with traefik is the Docker labels used in the docker-compose.yml files. Since isle-site-template and isle-dc have different docker-compose.yml files, there isn't any need to keep them in sync.

@joshdentremont
Copy link
Contributor Author

Updated this to use the newest version, 2.10.5

@aOelschlager aOelschlager merged commit b5d9361 into Islandora-Devops:development Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants