move to Github actions #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelgbanks
approved these changes
Apr 20, 2021
nigelgbanks
approved these changes
Apr 20, 2021
|
Changes look good to me, though the pull seems to be waiting on travis? Some admin settings on the repo might need changing? @dannylamb |
|
Haha, yep. One last attempt from Travis to thwart us. This'll be his last. |
dannylamb
approved these changes
Apr 21, 2021
|
I updated the branch protection settings to no longer wait for Travis. I'm not sure if it'll automatically wait for the Github Actions. It didn't give me an option to enable them in the branch protection rule. So maybe I'll need to circle back to this 🤷♂️ |
This was referenced Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
replace travis with github actions
What's new?
replace travis with github actions
How should this be tested?
See if the build is successful
You can see the successful build over here: https://github.com/asulibraries/carapace/actions/runs/768103184
This includes the work from #24
Interested parties
@Islandora/8-x-committers