Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Warning using 7.3 #1466

Closed
dannylamb opened this issue Mar 13, 2020 · 4 comments
Closed

PHP Warning using 7.3 #1466

dannylamb opened this issue Mar 13, 2020 · 4 comments

Comments

@dannylamb
Copy link
Contributor

Getting this nagging warning on ISLE for Islandora 8. We're using PHP 7.3 and are getting this:

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/html/web/modules/contrib/islandora/src/EventSubscriber/LinkHeaderSubscriber.php on line 286
@whikloj
Copy link
Member

whikloj commented Mar 14, 2020

I think we discussed this before, but for reference. https://wiki.php.net/rfc/continue_on_switch_deprecation

@dannylamb
Copy link
Contributor Author

It's eerily similar to another 7.3 warning I fixed recently.

@akuckartz
Copy link

Wait what will happen with 7.4 ;-)

@g7morris g7morris mentioned this issue Jun 11, 2020
Closed
@dannylamb dannylamb mentioned this issue Oct 19, 2020
Merged
@rosiel
Copy link
Member

rosiel commented Sep 11, 2021

Pretty sure this can be closed.

@rosiel rosiel closed this as completed Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@akuckartz @kstapelfeldt @rosiel @whikloj @dannylamb