Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 10 Compatibility #2235

Closed
rosiel opened this issue May 25, 2023 · 1 comment
Closed

Drupal 10 Compatibility #2235

rosiel opened this issue May 25, 2023 · 1 comment
Labels
Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)

Comments

@rosiel
Copy link
Member

rosiel commented May 25, 2023

Overview of feature request

Islandora code needs to work on Drupal 10 before the EOL of Drupal 9, which is fast approaching.

This is a meta-issue to link together work done in various repositories.

Basic steps that I've found useful (pls add/edit):

  • Run Drupal Rector on the module (on D9) to fix known deprecated code.
  • Run PHPUnit locally, and take note of deprecation notices (that aren't errors). This sometimes finds deprecations that Rector misses.
  • Install Upgrade Status and scan the code. Fix outstanding issues.
  • Declare the module compatible with Drupal 10. Install it on D10 and test that it still functions.
  • Fix problems that come up in the code in D10 that weren't caught by Rector or the other tools
  • Test the module again with Drupal 9 to make sure it still works. When there are incompatibilities in code (e.g. parent class signatures change) that mean a single codebase can't satisfy D9 and D10, we'll have to make a new major version branch for the Drupal 10 version.
  • Celebrate!
@rosiel
Copy link
Member Author

rosiel commented Aug 2, 2023

Appears to be complete with the starter site PR: Islandora-Devops/islandora-starter-site#105

@rosiel rosiel closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: feature request a proposal for a new feature in the software (should be justified by a ‘use case’)
Projects
None yet
Development

No branches or pull requests

1 participant