Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Video repository items are not showing the embedded viewer #21

Closed
nigelgbanks opened this issue Nov 8, 2022 · 8 comments
Closed
Labels
bug Something isn't working

Comments

@nigelgbanks
Copy link
Contributor

What steps does it take to reproduce the issue?

  • Start up a site based on islandora-starter-pack
  • Create a new Video repository item
  • Set Resource Type to Moving Image (Not sure if this is required any more, but to be safe)
  • Select N/A for the Display Hint Field
  • Add a Original File / Preservation Master video media entity to the repository item
  • Note that it does not display on the repository item

  • When does this issue occur?

When viewing a repository item.

  • Which page does it occur on?

The view page for the repository item.

  • What happens?

The video viewer does not display.

  • To whom does it occur (anonymous visitor, editor, administrator)?

To all users regardless of role.

  • What did you expect to happen?

The video viewer to display.

Which version of Islandora are you using?

2.4.3 (I was using 8a32258 of this repository)

Any related open or closed issues to this bug report?

N/A

Screenshots:

Repository Item View Page:
Screenshot 2022-11-08 at 12 12 01

Media Items:

Screenshot 2022-11-08 at 12 12 08

I can view the video on the browser by clicking the file link, no viewer display, though.

@nigelgbanks nigelgbanks added the bug Something isn't working label Nov 8, 2022
@rosiel
Copy link
Contributor

rosiel commented Nov 8, 2022

Yes! I think this is the issue of the contexts which (since defaults) assumed bartik. Changing this was considered out of scope for the move to the starter site, and it's been high on my mind, but I haven't had a chance to fix it yet. :(

@rosiel
Copy link
Contributor

rosiel commented Nov 8, 2022

OOPS NOPE that's not it - though that's an outstanding issue, I think the problem is that Video is configured to show a Service File and one's not being created. Sorry! This could be the derivatives problem that @aOelschlager identified, which IIRC can be solved if using the branch of Buildkit that uses a karaf-less Alpaca.

@rosiel
Copy link
Contributor

rosiel commented Nov 8, 2022

So... if you tag your existing file as a service file, does it display?

I think the configs at play are:

  • since you're not choosing a display hint (and starter site doesn't do as many contexts as the sandbox), you're on the default view mode
  • core.entity_view_display.node.islandora_object.default.yml displays "display_media_service_file"
  • which is the display_media view's service_file display

@nigelgbanks
Copy link
Contributor Author

The sandbox seems to show the embedded video player without a Service File tag. However, it does show if I add the Service File tag to the video.

@nigelgbanks
Copy link
Contributor Author

The sandbox also does not create a derivative, I should mention.

@rosiel
Copy link
Contributor

rosiel commented Nov 10, 2022

Sandbox is configured to create a Service File from an Original File. (Action, Context)
I can confirm that this did not happen for the video I uploaded.

Sandbox is configured to show the Original File EVA on the default display mode. This is, AFAIK, a deviation from the Starter Site/Defaults.

@rosiel rosiel added this to the Dec 2022 Mini-Sprint milestone Dec 8, 2022
@rosiel
Copy link
Contributor

rosiel commented Dec 9, 2022

Starter Site is configured to:

  • create a service file video from an original file
  • display the service file near the top of the page. It will show in the media's "source" view mode unless overridden by the view mode picker.
  • display the original file as a download link with filesize and hash.

What we haven't tackled is how to deal with times where you want to use the file you upload - the original file - as the service file for the purpose of display on the node's page.

My suggestion is to double-tag (upload a file and mark it as "Original File" and "Service File".) This seems the most intuitive. However, I don't want to suggest this until I'm sure it wont cause infinite loops of derivatives. I think at the moment that it might. A simple "check to see if the destination term uri is on the source media and stop if it is" would suffice. I think there are open issues about this:

@rosiel
Copy link
Contributor

rosiel commented Feb 27, 2023

Double-tagging no longer causes an infinite loop.
I am closing; this is working as intended.

@rosiel rosiel closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants