Update Contexts to Olivero / remove bartik blocks. #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Updates the contexts that place blocks (openseadragon - paged content and Collection) to place them in the olivero theme.
Related GitHub Issue:
[BUG] Contexts don't place blocks properly - Starter Site assumes theme is Bartik, but we have Olivero #10
Other Relevant Links: (Google Groups discussion, related pull requests,
Release pull requests, etc.)
What's new?
Openseadragon-paged content and collection now place their views in content_below in olivero.
Removed all the bartik blocks that aren't used anymore (as far as i can tell)
does NOT place the facet blocks (which are currently placed in Olivero) - that's a separate issue:
Does this change add any new dependencies? no
Does this change require any other modifications to be made to the repository
(i.e. Regeneration activity, etc.)? no
Could this change impact execution of existing code? no
How should this be tested?
Load it up (e.g. edit your Makefile in ISLE, then spin up a fresh starter_dev)
Make a collection and a child - does the view show?
Make a book and some pages - does the openseadragon viewer show?
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers