Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contexts to Olivero / remove bartik blocks. #24

Closed
wants to merge 2 commits into from

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Nov 9, 2022

What does this Pull Request do?

Updates the contexts that place blocks (openseadragon - paged content and Collection) to place them in the olivero theme.

Related GitHub Issue:

What's new?

  • Openseadragon-paged content and collection now place their views in content_below in olivero.

  • Removed all the bartik blocks that aren't used anymore (as far as i can tell)

  • does NOT place the facet blocks (which are currently placed in Olivero) - that's a separate issue:

  • Does this change add any new dependencies? no

  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no

  • Could this change impact execution of existing code? no

How should this be tested?

Load it up (e.g. edit your Makefile in ISLE, then spin up a fresh starter_dev)
Make a collection and a child - does the view show?
Make a book and some pages - does the openseadragon viewer show?

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? n/a
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@rosiel
Copy link
Contributor Author

rosiel commented Jan 5, 2023

Closing; superseded by #39

@rosiel rosiel closed this Jan 5, 2023
@rosiel rosiel deleted the olivero branch January 5, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant