Issue 1266 islandora pseudo bundles warning #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/kayakr/islandora into issue-1266-islandora-pseudo_bundles-warning
|
It's not letting me approve this since it thinks it's from me, but it's really @kayakr 's and ima gonna merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All work done by @kayakr. Can't take any credit for this one. I just migrated the PR over from Islandora/documentation#158
GitHub Issue:
Islandora/documentation#1266
What does this Pull Request do?
Fix PHP warning arising from no selection of bundles with Gemini URI pseudo field.
http://localhost:8000/admin/config/islandora/core
How should this be tested?
We're seeing this warning on pre-1.0.0 instances. It doesn't appear to happen on a fresh VM since at least some bundles are selected. With no bundles selected warning does not occur, even with no patch.
Interested parties
@Islandora-CLAW/committers