Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes JSONLD endpoint fail for Extracted Text #768

Merged
merged 4 commits into from
Apr 1, 2020
Merged

Conversation

dannylamb
Copy link

@dannylamb dannylamb commented Mar 31, 2020

JIRA Ticket: Resolves Islandora/documentation#1477

What does this Pull Request do?

Adds an RDF mapping for extracted text media. Also touches up the JsonldTypeAlterReaction so it doesn't WSOD if there's ever another missing RDF mapping.

How should this be tested?

  • Visit the ?_format=jsonld endpoint for an extracted_text media.
  • You'll WSOD
  • Apply this PR
  • drush -y fim islandora_text_extraction_defaults
  • Visit the ?_format=jsonld endpoint again
  • No WSOD

Interested parties

@Islandora/8-x-committers

@dannylamb dannylamb changed the title wrapping string in array for case where there's no rdf mapping Fixes JSONLD endpoint fail for Extracted Text Mar 31, 2020
@dannylamb
Copy link
Author

Despite being logged in as me, I cannot restart the build on Travis. Any @Islandora/8-x-committers out there willing to try and restart this build for me? This is the one repo still on travis-ci.org and not .com, which might explain why I don't have perms?'

@seth-shaw-unlv
Copy link

It won't let me restart it either, @dannylamb.

@dannylamb
Copy link
Author

@whikloj You got a button to restart builds on this repo?

I just pushed up a whitespace commit to trigger travis, but at least one of us has to have the ability.

Copy link

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. 👍

@seth-shaw-unlv seth-shaw-unlv merged commit 8b7caa9 into 8.x-1.x Apr 1, 2020
@seth-shaw-unlv seth-shaw-unlv deleted the issue-1477 branch April 1, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants