Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use islandora_ci for scripts #806

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Conversation

dannylamb
Copy link

JIRA Ticket: Part of Islandora/documentation#1672, which is meant to clear out Islandora/documenation so that it can have looser merging privileges

What does this Pull Request do?

Uses the newly extracted Islandora/islandora_ci for travis scripts instead of Islandora/documentation.

How should this be tested?

Travis should be green.

Interested parties

@Islandora/8-x-committers

@seth-shaw-unlv
Copy link

Composer 2 is failing:

composer install drupal site
Cloning into 'drupal'...
No lock file found. Updating dependencies instead of installing from lock file. Use composer update over composer install if you do not have a lock file.
> DrupalProject\composer\ScriptHandler::checkComposerVersion
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.
  Problem 1
    - drupal/console[1.0.2, ..., 1.9.5] require drupal/console-extend-plugin ~0 -> satisfiable by drupal/console-extend-plugin[0.1.0, ..., 0.9.4].
    - drupal/console-extend-plugin[0.1.0, ..., 0.9.4] require composer-plugin-api ^1.0 -> found composer-plugin-api[2.0.0] but it does not match the constraint.
    - Root composer.json requires drupal/console ^1.0.2 -> satisfiable by drupal/console[1.0.2, ..., 1.9.5].
You are using Composer 2, which some of your plugins seem to be incompatible with. Make sure you update your plugins or report a plugin-issue to ask them to support Composer 2.
Setup Drush
Drush setup drupal site
/home/travis/islandora_ci/travis_setup_drupal.sh: line 36: cd: web: No such file or directory
/home/travis/islandora_ci/travis_setup_drupal.sh: line 37: drush: command not found
/home/travis/islandora_ci/travis_setup_drupal.sh: line 38: drush: command not found

@dannylamb
Copy link
Author

PHP 7.2 is barfing on composer 2. Running composer update with a fresh composer 2 installation gives me this 😭

danny@danny-XPS-13-7390:~/Code/Islandora/islandora$ php composer.phar update
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires drupal/context ^4.0, found drupal/context[dev-4.x, 4.0.0-beta1, ..., 4.x-dev (alias of dev-4.x)] but it does not match your minimum-stability.
  Problem 2
    - Root composer.json requires islandora/crayfish-commons dev-dev -> satisfiable by islandora/crayfish-commons[dev-dev].
    - islandora/crayfish-commons dev-dev requires islandora/chullo dev-dev -> found islandora/chullo[dev-dev] but it does not match your minimum-stability.

@dannylamb
Copy link
Author

Oh noes... I think I have to use composer 2 to update all the things...

@dannylamb
Copy link
Author

And man, shoulda refreshed... Looks like it popped on a different package for you @seth-shaw-unlv. This'll be fun.

@dannylamb
Copy link
Author

Ok, it's looking like drupal console isn't composer 2 ready at the moment. I think we can pull it from composer and install it globally instead to dance around this. I'll start by deleting it and seeing how deep this rabbit hole goes.

@elizoller
Copy link
Member

elizoller commented Nov 5, 2020

@dannylamb does this help you at all: hechoendrupal/drupal-console-extend-plugin#23 ?
found it from here: hechoendrupal/drupal-console#4278

@dannylamb
Copy link
Author

dannylamb commented Nov 5, 2020

We can wait for hechoendrupal/drupal-console-extend-plugin#25 if we want, but I did delete drupal/console from our composer.json and everything builds fine. We can just install it globally if we need it in the playbook or ISLE: https://drupalconsole.com/docs/en/getting/launcher and we'll be fine.

I've pushed up a branch to drupal-project and am trying to test it with islandora_ci right now.

@elizoller
Copy link
Member

sounds good

@dannylamb
Copy link
Author

Awww yisss. We are green.

I'll make a PR for drupal-project

@dannylamb
Copy link
Author

This is good to go now

Copy link

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seth-shaw-unlv seth-shaw-unlv merged commit 4f2c58e into 8.x-1.x Nov 9, 2020
@whikloj whikloj deleted the update-scripts-location branch December 16, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants