-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use islandora_ci for scripts #806
Conversation
Composer 2 is failing:
|
PHP 7.2 is barfing on composer 2. Running
|
Oh noes... I think I have to use composer 2 to update all the things... |
And man, shoulda refreshed... Looks like it popped on a different package for you @seth-shaw-unlv. This'll be fun. |
Ok, it's looking like drupal console isn't composer 2 ready at the moment. I think we can pull it from composer and install it globally instead to dance around this. I'll start by deleting it and seeing how deep this rabbit hole goes. |
@dannylamb does this help you at all: hechoendrupal/drupal-console-extend-plugin#23 ? |
We can wait for hechoendrupal/drupal-console-extend-plugin#25 if we want, but I did delete drupal/console from our composer.json and everything builds fine. We can just install it globally if we need it in the playbook or ISLE: https://drupalconsole.com/docs/en/getting/launcher and we'll be fine. I've pushed up a branch to drupal-project and am trying to test it with islandora_ci right now. |
sounds good |
Awww yisss. We are green. I'll make a PR for |
This is good to go now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
JIRA Ticket: Part of Islandora/documentation#1672, which is meant to clear out Islandora/documenation so that it can have looser merging privileges
What does this Pull Request do?
Uses the newly extracted Islandora/islandora_ci for travis scripts instead of Islandora/documentation.
How should this be tested?
Travis should be green.
Interested parties
@Islandora/8-x-committers