Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newspaper #63

Closed
wants to merge 3 commits into from
Closed

Newspaper #63

wants to merge 3 commits into from

Conversation

Natkeeran
Copy link
Contributor

@Natkeeran Natkeeran commented Dec 9, 2021

GitHub Issue: (link)

What does this Pull Request do?

I've refactored to package the newspaper functionality for islandora from install profile.

The main logic is packaged into its own module: https://github.com/Natkeeran/views_nested_details.

Almost as it is from the install profile except for minor default css for the accordion.

The view and context for block placement is packaged into a small sub module in this PR.

There is a known issue with Month display in the EDTF formatter (1970-February vs February).

How should this be tested?

@rosiel
Copy link
Member

rosiel commented Dec 15, 2021

There appears to be an accidental .swp file that made its way in.

@seth-shaw-unlv seth-shaw-unlv self-requested a review June 1, 2022 17:07
@seth-shaw-unlv
Copy link
Contributor

Should we transfer https://github.com/Natkeeran/views_nested_details to the Islandora foundation or make it a Drupal project before we add it as a sub-module dependency?

@seth-shaw-unlv
Copy link
Contributor

@Natkeeran, can we add a README to the newspaper submodule with instructions on installing views_nested_details especially since it is now a prerequisite and it currently won't get picked up with composer.

@rosiel
Copy link
Member

rosiel commented Jun 12, 2024

Default has been deprecated in favour of the Islandora Starter Site.
This functionality was added to the Starter Site: Islandora-Devops/islandora-starter-site#60

@rosiel rosiel closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants