Skip to content

Commit

Permalink
Fix CI welcome message (bevyengine#7428)
Browse files Browse the repository at this point in the history
# Objective

Fixes bevyengine#7424

## Solution

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target
> By default, a workflow only runs when a pull_request_target event's activity type is opened, synchronize, or reopened.

Specify `opened` so that this only runs when a PR is opened

While I was in there, I fixed a couple other issues:
- extra indentation that was causing the welcome message to be put in a code block.
- broken relative link in message (was resolving to <https://github.com/bevyengine/bevy/pull/CONTRIBUTING.md>)
- fixed a few other minor typos in the message

cc @mockersf
  • Loading branch information
rparrett authored and ItsDoot committed Feb 1, 2023
1 parent cf2e229 commit f654b07
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/welcome.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ name: Welcome new contributors
# This workflow has write permissions on the repo
# It must not checkout a PR and run untrusted code

on: pull_request_target
on:
pull_request_target:
types:
- opened

jobs:
welcome:
Expand Down Expand Up @@ -38,5 +41,5 @@ jobs:
repo: context.repo.repo,
body: `**Welcome**, new contributor!
Please make sure you're read our [contributing guide](CONTRIBUTING.md) and we look forward to reviewing your Pull request shortly ✨`
Please make sure you've read our [contributing guide](https://github.com/bevyengine/bevy/blob/main/CONTRIBUTING.md) and we look forward to reviewing your pull request shortly ✨`
})

0 comments on commit f654b07

Please sign in to comment.