Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web-based Search should support web-fetcher syntax #608

Open
koppor opened this issue Sep 2, 2022 · 0 comments
Open

Web-based Search should support web-fetcher syntax #608

koppor opened this issue Sep 2, 2022 · 0 comments
Labels

Comments

@koppor
Copy link
Member

koppor commented Sep 2, 2022

As user, I "just" want to search

  • If I enter a DOI in the web search, the DOI should be searched (independent of the selected fetcher)
  • When I enter a custom key/value pair, I want that key/value pair to be passed to the fetcher (and not be deleted)
  • When I enter a syntax custom to the fetcher, I want that syntax be passed to the fetcher (and not be rejected). Example: Search in GVK: User may use Lucene syntax or GVK syntax.

Implementation Idea:

  1. Check for Id --> run id fetcher
  2. Check for syntax of fetcher -> if match -> pass that
    • Is there a parser for the fetcher?
  3. Check for lucene syntax --> if match -> pass that
    • Lucene might return that it cannot parse a field --> maybe raw needs to be sent
  4. Show error

Can we show the "mode" in the UI - like we did at the magnification glass at the search in JabRef 2.x?

  • Valid query, just terms: grafik
  • Valid query, advanced search active, something found: grafik
  • Valid query, advanced search active, nothing found: grafik
  • Valid query, basic search active, something found: grafik

grafik


Currently:

  • Invalid query: grafik

This is currently sketched in the FetcherDelegate: https://github.com/koppor/jabref/pull/559/files#diff-6038155da69f4a45d14bde97e0718d663aa19d6e181eecbfe938b1c65d548cf8

@koppor koppor added the SLR label Sep 2, 2022
@koppor koppor moved this to Backlog in SLR Kanban Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant