diff --git a/config/IntelliJ Code Style.xml b/config/IntelliJ Code Style.xml
index 489f44c1a5c..6a03e104d9d 100644
--- a/config/IntelliJ Code Style.xml
+++ b/config/IntelliJ Code Style.xml
@@ -1,37 +1,38 @@
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
@@ -292,4 +293,4 @@
-
+
\ No newline at end of file
diff --git a/config/checkstyle/checkstyle.xml b/config/checkstyle/checkstyle.xml
index 2de4703981a..ade463b0d6c 100644
--- a/config/checkstyle/checkstyle.xml
+++ b/config/checkstyle/checkstyle.xml
@@ -26,6 +26,10 @@
+
+
+
+
@@ -35,6 +39,7 @@
+
@@ -85,6 +90,9 @@
+
+
+
@@ -99,16 +107,25 @@
public String getTabName() { return Localization.lang("XMP metadata"); }
- Since it is too much effort to reformat all code, it is currently not enabled -->
-
+ -->
+
+
+
+
+
+
+
+
+
+
diff --git a/docs/guidelines-for-setting-up-a-local-workspace.md b/docs/guidelines-for-setting-up-a-local-workspace.md
index 5a6462d654d..94faa6196e0 100644
--- a/docs/guidelines-for-setting-up-a-local-workspace.md
+++ b/docs/guidelines-for-setting-up-a-local-workspace.md
@@ -170,9 +170,10 @@ Contributions to JabRef's source code need to have a code formatting that is con
4. Check "Store relative to project location"
5. Click "Next" and "Finish"
6. Activate the CheckStyle configuration file by ticking it in the list
- 7. Ensure that CheckStyle version 8.31 (or higher) is selected
- 8. Save settings by clicking "OK"
- 9. Your configuration should now look like this:
+ 7. Ensure that the latest CheckStyle version is selected (8.32 or higher)
+ 8. Set the "Scan Scope" to "Only Java sources (including tests)
+ 9. Save settings by clicking "OK"
+ 10. Your configuration should now look like this:
#### Troubleshooting when using both IDEA and Eclipse
diff --git a/docs/images/intellij-checkstyle-settings.png b/docs/images/intellij-checkstyle-settings.png
index c605c04cd20..e5f0c027190 100644
Binary files a/docs/images/intellij-checkstyle-settings.png and b/docs/images/intellij-checkstyle-settings.png differ
diff --git a/src/main/java/org/jabref/Globals.java b/src/main/java/org/jabref/Globals.java
index 4ee99f58804..a03fbfc5ac9 100644
--- a/src/main/java/org/jabref/Globals.java
+++ b/src/main/java/org/jabref/Globals.java
@@ -59,12 +59,14 @@ public class Globals {
/**
* This field is initialized upon startup.
+ *
* Only GUI code is allowed to access it, logic code should use dependency injection.
*/
public static JournalAbbreviationRepository journalAbbreviationRepository;
/**
* This field is initialized upon startup.
+ *
* Only GUI code is allowed to access it, logic code should use dependency injection.
*/
public static ProtectedTermsLoader protectedTermsLoader;
diff --git a/src/main/java/org/jabref/JabRefException.java b/src/main/java/org/jabref/JabRefException.java
index a1dd034d89e..316dcc5e7ad 100644
--- a/src/main/java/org/jabref/JabRefException.java
+++ b/src/main/java/org/jabref/JabRefException.java
@@ -39,5 +39,4 @@ public String getLocalizedMessage() {
return localizedMessage;
}
}
-
}
diff --git a/src/main/java/org/jabref/JabRefExecutorService.java b/src/main/java/org/jabref/JabRefExecutorService.java
index 762d0dd66d2..a90668d9bd2 100644
--- a/src/main/java/org/jabref/JabRefExecutorService.java
+++ b/src/main/java/org/jabref/JabRefExecutorService.java
@@ -28,7 +28,6 @@ public class JabRefExecutorService {
thread.setName("JabRef CachedThreadPool");
thread.setUncaughtExceptionHandler(new FallbackExceptionHandler());
return thread;
-
});
private final ExecutorService lowPriorityExecutorService = Executors.newCachedThreadPool(r -> {
Thread thread = new Thread(r);
@@ -165,5 +164,4 @@ public void run() {
}
}
}
-
}
diff --git a/src/main/java/org/jabref/JabRefMain.java b/src/main/java/org/jabref/JabRefMain.java
index b2b78566c08..e004d0e1627 100644
--- a/src/main/java/org/jabref/JabRefMain.java
+++ b/src/main/java/org/jabref/JabRefMain.java
@@ -114,9 +114,9 @@ private static void ensureCorrectJavaVersion() {
if (java9Fail || versionFail) {
StringBuilder versionError = new StringBuilder(
- Localization.lang("Your current Java version (%0) is not supported. Please install version %1 or higher.",
- checker.getJavaVersion(),
- buildInfo.minRequiredJavaVersion));
+ Localization.lang("Your current Java version (%0) is not supported. Please install version %1 or higher.",
+ checker.getJavaVersion(),
+ buildInfo.minRequiredJavaVersion));
versionError.append("\n");
versionError.append(Localization.lang("Your Java Runtime Environment is located at %0.", checker.getJavaInstallationDirectory()));
@@ -165,7 +165,7 @@ private static void applyPreferences(JabRefPreferences preferences) {
// Build list of Import and Export formats
Globals.IMPORT_FORMAT_READER.resetImportFormats(Globals.prefs.getImportFormatPreferences(),
- Globals.prefs.getXMPPreferences(), Globals.getFileUpdateMonitor());
+ Globals.prefs.getXMPPreferences(), Globals.getFileUpdateMonitor());
Globals.entryTypesManager.addCustomOrModifiedTypes(preferences.loadBibEntryTypes(BibDatabaseMode.BIBTEX),
preferences.loadBibEntryTypes(BibDatabaseMode.BIBLATEX));
Globals.exportFactory = Globals.prefs.getExporterFactory(Globals.journalAbbreviationRepository);
diff --git a/src/main/java/org/jabref/architecture/ApacheCommonsLang3Allowed.java b/src/main/java/org/jabref/architecture/ApacheCommonsLang3Allowed.java
index f398c11f56e..95aa6c0949b 100644
--- a/src/main/java/org/jabref/architecture/ApacheCommonsLang3Allowed.java
+++ b/src/main/java/org/jabref/architecture/ApacheCommonsLang3Allowed.java
@@ -8,5 +8,4 @@
// The rationale
String value();
-
}
diff --git a/src/main/java/org/jabref/cli/ArgumentProcessor.java b/src/main/java/org/jabref/cli/ArgumentProcessor.java
index 603eba4a411..957a0fab500 100644
--- a/src/main/java/org/jabref/cli/ArgumentProcessor.java
+++ b/src/main/java/org/jabref/cli/ArgumentProcessor.java
@@ -266,7 +266,7 @@ private boolean exportMatches(List loaded) {
break;
default:
System.err.println(Localization.lang("Output file missing").concat(". \n \t ")
- .concat(Localization.lang("Usage")).concat(": ") + JabRefCLI.getExportMatchesSyntax());
+ .concat(Localization.lang("Usage")).concat(": ") + JabRefCLI.getExportMatchesSyntax());
noGUINeeded = true;
return false;
}
@@ -442,7 +442,7 @@ private void exportFile(List loaded, String[] data) {
try {
exporter.get().export(pr.getDatabaseContext(), Path.of(data[0]),
pr.getDatabaseContext().getMetaData().getEncoding()
- .orElse(Globals.prefs.getDefaultEncoding()),
+ .orElse(Globals.prefs.getDefaultEncoding()),
pr.getDatabaseContext().getDatabase().getEntries());
} catch (Exception ex) {
System.err.println(Localization.lang("Could not export file") + " '" + data[0] + "': "
@@ -516,8 +516,7 @@ private void regenerateBibtexKeys(List loaded) {
/**
* Run an entry fetcher from the command line.
*
- * @param fetchCommand A string containing both the name of the fetcher to use and
- * the search query, separated by a :
+ * @param fetchCommand A string containing both the name of the fetcher to use and the search query, separated by a :
* @return A parser result containing the entries fetched or null if an error occurred.
*/
private Optional fetch(String fetchCommand) {
diff --git a/src/main/java/org/jabref/cli/CrossrefFetcherEvaluator.java b/src/main/java/org/jabref/cli/CrossrefFetcherEvaluator.java
index 69641fa60c7..6db58af18c0 100644
--- a/src/main/java/org/jabref/cli/CrossrefFetcherEvaluator.java
+++ b/src/main/java/org/jabref/cli/CrossrefFetcherEvaluator.java
@@ -71,7 +71,6 @@ public void run() {
} catch (FetcherException e) {
e.printStackTrace();
}
-
} else {
try {
Optional crossrefDOI = new CrossRef().findIdentifier(entry);
@@ -86,7 +85,6 @@ public void run() {
countDownLatch.countDown();
}
});
-
}
countDownLatch.await();
diff --git a/src/main/java/org/jabref/cli/GenerateCharacterTable.java b/src/main/java/org/jabref/cli/GenerateCharacterTable.java
index babd5bbca00..57a1690bb10 100644
--- a/src/main/java/org/jabref/cli/GenerateCharacterTable.java
+++ b/src/main/java/org/jabref/cli/GenerateCharacterTable.java
@@ -39,14 +39,12 @@ public static void main(String[] args) {
System.out
.println(
character.getKey() + " & "
- + ((character.getKey() > 128) ? String
- .valueOf(Character.toChars(character.getKey())) : "")
+ + ((character.getKey() > 128) ?
+ String.valueOf(Character.toChars(character.getKey())) : "")
+ " & \\symbol{" + Integer.toString(character.getKey()) + "} & "
+ character.getValue() + " & \\verb¤" + character.getValue() + "¤ \\\\");
}
System.out.println("\\end{supertabular}");
System.out.println("\\end{document}");
-
}
-
}
diff --git a/src/main/java/org/jabref/cli/JabRefCLI.java b/src/main/java/org/jabref/cli/JabRefCLI.java
index 0f3baecdf59..167875b322d 100644
--- a/src/main/java/org/jabref/cli/JabRefCLI.java
+++ b/src/main/java/org/jabref/cli/JabRefCLI.java
@@ -162,75 +162,85 @@ private static Options getOptions() {
// The "-console" option is handled by the install4j launcher
options.addOption(null, "console", false, Localization.lang("Show console output (only when the launcher is used)"));
- options.addOption(Option.builder("i").
- longOpt("import").
- desc(String.format("%s: '%s'", Localization.lang("Import file"), "-i library.bib")).
- hasArg().
- argName("FILE[,FORMAT]").
- build());
-
- options.addOption(Option.builder().
- longOpt("importToOpen").
- desc(Localization.lang("Same as --import, but will be imported to the opened tab")).
- hasArg().
- argName("FILE[,FORMAT]").
- build());
-
- options.addOption(Option.builder("ib").
- longOpt("importBibtex").
- desc(String.format("%s: '%s'", Localization.lang("Import BibTeX"), "-ib @article{entry}")).
- hasArg().
- argName("BIBTEXT_STRING").
- build());
-
- options.addOption(Option.builder("o").
- longOpt("output").
- desc(String.format("%s: '%s'", Localization.lang("Export an input to a file"), "-i db.bib -o db.htm,html")).
- hasArg().
- argName("FILE[,FORMAT]").
- build());
-
- options.addOption(Option.builder("m").
- longOpt("exportMatches").
- desc(String.format("%s: '%s'", Localization.lang("Matching"), "-i db.bib -m author=Newton,search.htm,html")).
- hasArg().
- argName("QUERY,FILE[,FORMAT]").
- build());
-
- options.addOption(Option.builder("f").
- longOpt("fetch").
- desc(String.format("%s: '%s'", Localization.lang("Run fetcher"), "-f Medline/PubMed:cancer")).
- hasArg().
- argName("FETCHER:QUERY").
- build());
-
- options.addOption(Option.builder("a").
- longOpt("aux").
- desc(String.format("%s: '%s'", Localization.lang("Sublibrary from AUX to BibTeX"), "-a thesis.aux,new.bib")).
- hasArg().
- argName("FILE[.aux],FILE[.bib] FILE").
- build());
-
- options.addOption(Option.builder("x").
- longOpt("prexp").
- desc(String.format("%s: '%s'", Localization.lang("Export preferences to a file"), "-x prefs.xml")).
- hasArg().
- argName("[FILE]").
- build());
-
- options.addOption(Option.builder("p").
- longOpt("primp").
- desc(String.format("%s: '%s'", Localization.lang("Import preferences from a file"), "-p prefs.xml")).
- hasArg().
- argName("[FILE]").
- build());
-
- options.addOption(Option.builder("d").
- longOpt("prdef").
- desc(String.format("%s: '%s'", Localization.lang("Reset preferences"), "-d mainFontSize,newline' or '-d all")).
- hasArg().
- argName("KEY1[,KEY2][,KEYn] | all").
- build());
+ options.addOption(Option
+ .builder("i")
+ .longOpt("import")
+ .desc(String.format("%s: '%s'", Localization.lang("Import file"), "-i library.bib"))
+ .hasArg()
+ .argName("FILE[,FORMAT]")
+ .build());
+
+ options.addOption(Option
+ .builder()
+ .longOpt("importToOpen")
+ .desc(Localization.lang("Same as --import, but will be imported to the opened tab"))
+ .hasArg()
+ .argName("FILE[,FORMAT]")
+ .build());
+
+ options.addOption(Option
+ .builder("ib")
+ .longOpt("importBibtex")
+ .desc(String.format("%s: '%s'", Localization.lang("Import BibTeX"), "-ib @article{entry}"))
+ .hasArg()
+ .argName("BIBTEXT_STRING")
+ .build());
+
+ options.addOption(Option
+ .builder("o")
+ .longOpt("output")
+ .desc(String.format("%s: '%s'", Localization.lang("Export an input to a file"), "-i db.bib -o db.htm,html"))
+ .hasArg()
+ .argName("FILE[,FORMAT]")
+ .build());
+
+ options.addOption(Option
+ .builder("m")
+ .longOpt("exportMatches")
+ .desc(String.format("%s: '%s'", Localization.lang("Matching"), "-i db.bib -m author=Newton,search.htm,html"))
+ .hasArg()
+ .argName("QUERY,FILE[,FORMAT]")
+ .build());
+
+ options.addOption(Option
+ .builder("f")
+ .longOpt("fetch")
+ .desc(String.format("%s: '%s'", Localization.lang("Run fetcher"), "-f Medline/PubMed:cancer"))
+ .hasArg()
+ .argName("FETCHER:QUERY")
+ .build());
+
+ options.addOption(Option
+ .builder("a")
+ .longOpt("aux")
+ .desc(String.format("%s: '%s'", Localization.lang("Sublibrary from AUX to BibTeX"), "-a thesis.aux,new.bib"))
+ .hasArg()
+ .argName("FILE[.aux],FILE[.bib] FILE")
+ .build());
+
+ options.addOption(Option
+ .builder("x")
+ .longOpt("prexp")
+ .desc(String.format("%s: '%s'", Localization.lang("Export preferences to a file"), "-x prefs.xml"))
+ .hasArg()
+ .argName("[FILE]")
+ .build());
+
+ options.addOption(Option
+ .builder("p")
+ .longOpt("primp")
+ .desc(String.format("%s: '%s'", Localization.lang("Import preferences from a file"), "-p prefs.xml"))
+ .hasArg()
+ .argName("[FILE]")
+ .build());
+
+ options.addOption(Option
+ .builder("d")
+ .longOpt("prdef")
+ .desc(String.format("%s: '%s'", Localization.lang("Reset preferences"), "-d mainFontSize,newline' or '-d all"))
+ .hasArg()
+ .argName("KEY1[,KEY2][,KEYn] | all")
+ .build());
return options;
}
diff --git a/src/main/java/org/jabref/gui/Base.css b/src/main/java/org/jabref/gui/Base.css
index 9d8f0a00ee8..03354abd72f 100644
--- a/src/main/java/org/jabref/gui/Base.css
+++ b/src/main/java/org/jabref/gui/Base.css
@@ -155,19 +155,19 @@
*/
-fx-color: -fx-base;
- -fx-hover-base: derive(-fx-base,30%);
+ -fx-hover-base: derive(-fx-base, 30%);
/* A little darker than -fx-base and used as the -fx-color for the
* "armed" pseudoclass state.
*
* TODO: should this be renamed to -fx-armed-base?
*/
- -fx-pressed-base: derive(-fx-base,-6%);
+ -fx-pressed-base: derive(-fx-base, -6%);
/* A little darker than -fx-color and used to draw boxes around objects such
* as progress bars, scroll bars, scroll panes, trees, tables, and lists.
*/
- -fx-box-border: derive(-fx-color,-5%);
+ -fx-box-border: derive(-fx-color, -5%);
/* Darker than -fx-background and used to draw boxes around text boxes and
* password boxes.
@@ -178,7 +178,7 @@
* needed on top of -fx-background. This is never a shadow in Modena but
* keep -fx-shadow-highlight-color name to be compatible with Caspian.
*/
- -fx-shadow-highlight-color: rgba(255,255,255,0.07) 70%;
+ -fx-shadow-highlight-color: rgba(255, 255, 255, 0.07) 70%;
/* A gradient that goes from a little darker than -fx-color on the top to
* even more darker than -fx-color on the bottom. Typically is the second
@@ -186,16 +186,16 @@
* a control. It is typically the same size as the control (i.e., insets
* are 0).
*/
- -fx-outer-border: derive(-fx-color,-5%);
+ -fx-outer-border: derive(-fx-color, -5%);
/* A gradient that goes from a bit lighter than -fx-color on the top to
* a little darker at the bottom. Typically is the third color in the
* -fx-background-color list as a thin highlight inside the outer border.
* Insets are typically 1.
*/
- -fx-inner-border: derive(-fx-color,65%);
- -fx-inner-border-horizontal: derive(-fx-color,65%);
- -fx-inner-border-bottomup: derive(-fx-color,65%);
+ -fx-inner-border: derive(-fx-color, 65%);
+ -fx-inner-border-horizontal: derive(-fx-color, 65%);
+ -fx-inner-border-bottomup: derive(-fx-color, 65%);
/*-fx-inner-border: red;*/
/*-fx-inner-border-horizontal: green;*/
@@ -205,9 +205,9 @@
* a little darker than -fx-color at the bottom and is used to fill the
* body of many controls such as buttons.
*/
- -fx-body-color: derive(-fx-color,20%);
- -fx-body-color-bottomup: derive(-fx-color,20%);
- -fx-body-color-to-right: derive(-fx-color,20%);
+ -fx-body-color: derive(-fx-color, 20%);
+ -fx-body-color-bottomup: derive(-fx-color, 20%);
+ -fx-body-color-to-right: derive(-fx-color, 20%);
/* The small thin light "shadow" for mark-like objects. Typically used in
* conjunction with -fx-mark-color with an insets of 1 0 -1 0. */
@@ -234,7 +234,7 @@
-fx-padding: inherit;
/** Focus line for keyboard focus traversal on cell based controls */
- -fx-cell-focus-inner-border: derive(-fx-selection-bar,30%);
+ -fx-cell-focus-inner-border: derive(-fx-selection-bar, 30%);
-fx-focused-mark-color: -fx-focused-text-base-color;
@@ -499,7 +499,7 @@
-fx-border-width: 3 0 0 0;
}
-.tab-pane > .tab-header-area > .headers-region > .tab:selected .tab-label{
+.tab-pane > .tab-header-area > .headers-region > .tab:selected .tab-label {
-fx-fill: -jr-theme-text;
-fx-text-fill: -jr-theme-text;
}
@@ -633,7 +633,7 @@
.table-cell:invalid,
.list-cell:invalid {
- -fx-background-color: -jr-warn;
+ -fx-background-color: -jr-warn;
}
.combo-box-base {
@@ -816,7 +816,7 @@
-fx-padding: 0.3em 0.9em 0.3em 0.9em;
}
-.sidePaneComponentHeader .glyph-icon{
+.sidePaneComponentHeader .glyph-icon {
-fx-fill: -jr-sidepane-header-color;
-fx-text-fill: -jr-sidepane-header-color;
-fx-font-size: 16px;
@@ -966,7 +966,7 @@ We want to have a look that matches our icons in the tool-bar */
-fx-fill: -jr-head-fg;
}
-.table-cell, .table-cell .glyph-icon{
+.table-cell, .table-cell .glyph-icon {
-fx-padding: 0.5em 1em 0.5em 1em;
-fx-cell-size: 4.0em;
-fx-text-fill: -fx-text-background-color;
diff --git a/src/main/java/org/jabref/gui/BasePanel.java b/src/main/java/org/jabref/gui/BasePanel.java
index 69c931b2344..1e6d3a0ed74 100644
--- a/src/main/java/org/jabref/gui/BasePanel.java
+++ b/src/main/java/org/jabref/gui/BasePanel.java
@@ -252,24 +252,24 @@ public void insertEntry(final BibEntry bibEntry) {
public void insertEntries(final List entries) {
if (!entries.isEmpty()) {
- bibDatabaseContext.getDatabase().insertEntries(entries);
-
- // Set owner and timestamp
- for (BibEntry entry : entries) {
- UpdateField.setAutomaticFields(entry,
- true,
- true,
- Globals.prefs.getOwnerPreferences(),
- Globals.prefs.getTimestampPreferences());
- }
- // Create an UndoableInsertEntries object.
- getUndoManager().addEdit(new UndoableInsertEntries(bibDatabaseContext.getDatabase(), entries));
+ bibDatabaseContext.getDatabase().insertEntries(entries);
+
+ // Set owner and timestamp
+ for (BibEntry entry : entries) {
+ UpdateField.setAutomaticFields(entry,
+ true,
+ true,
+ Globals.prefs.getOwnerPreferences(),
+ Globals.prefs.getTimestampPreferences());
+ }
+ // Create an UndoableInsertEntries object.
+ getUndoManager().addEdit(new UndoableInsertEntries(bibDatabaseContext.getDatabase(), entries));
- markBaseChanged(); // The database just changed.
- if (Globals.prefs.getBoolean(JabRefPreferences.AUTO_OPEN_FORM)) {
- showAndEdit(entries.get(0));
- }
- clearAndSelect(entries.get(0));
+ markBaseChanged(); // The database just changed.
+ if (Globals.prefs.getBoolean(JabRefPreferences.AUTO_OPEN_FORM)) {
+ showAndEdit(entries.get(0));
+ }
+ clearAndSelect(entries.get(0));
}
}
diff --git a/src/main/java/org/jabref/gui/Dark.css b/src/main/java/org/jabref/gui/Dark.css
index 6c92cf74e4e..e0b19e2adc5 100644
--- a/src/main/java/org/jabref/gui/Dark.css
+++ b/src/main/java/org/jabref/gui/Dark.css
@@ -57,9 +57,9 @@
-jr-drag-target-hover: -jr-accent;
}
-#previewBody{
+#previewBody {
background-color: #272b38; /* -fx-control-inner-background*/
- color : #7d8591; /* -fx-mid-text-color*/
+ color: #7d8591; /* -fx-mid-text-color*/
}
.table-view .groupColumnBackground {
diff --git a/src/main/java/org/jabref/gui/DialogService.java b/src/main/java/org/jabref/gui/DialogService.java
index 87da6a3b517..b8920fd70bb 100644
--- a/src/main/java/org/jabref/gui/DialogService.java
+++ b/src/main/java/org/jabref/gui/DialogService.java
@@ -30,7 +30,7 @@ public interface DialogService {
* This will create and display new {@link ChoiceDialog} of type T with a default choice and a collection of possible choices
*
* @implNote The implementation should accept {@code null} for {@code defaultChoice}, but callers should use {@link #showChoiceDialogAndWait(String, String, String, Collection)}.
- */
+ */
Optional showChoiceDialogAndWait(String title, String content, String okButtonLabel, T defaultChoice, Collection choices);
/**
@@ -189,10 +189,9 @@ Optional showCustomButtonDialogAndWait(Alert.AlertType type, String
/**
* Constructs and shows a canceable {@link ProgressDialog}. Clicking cancel will cancel the underlying service and close the dialog
*
- * @param title title of the dialog
+ * @param title title of the dialog
* @param content message to show above the progress bar
- * @param task The {@link Task} which executes the work and for which to show the dialog
- * @return
+ * @param task The {@link Task} which executes the work and for which to show the dialog
*/
Optional showProgressDialogAndWait(String title, String content, Task task);
@@ -201,10 +200,9 @@ Optional showCustomButtonDialogAndWait(Alert.AlertType type, String
* Clicking cancel will cancel the underlying service and close the dialog.
* The dialog will exit as soon as none of the background tasks are running
*
- * @param title title of the dialog
- * @param content message to show below the list of background tasks
+ * @param title title of the dialog
+ * @param content message to show below the list of background tasks
* @param stateManager The {@link StateManager} which contains the background tasks
- * @return
*/
Optional showBackgroundProgressDialogAndWait(String title, String content, StateManager stateManager);
diff --git a/src/main/java/org/jabref/gui/EntryType.fxml b/src/main/java/org/jabref/gui/EntryType.fxml
index 0ed5f37b502..da5daa62136 100644
--- a/src/main/java/org/jabref/gui/EntryType.fxml
+++ b/src/main/java/org/jabref/gui/EntryType.fxml
@@ -18,51 +18,51 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/src/main/java/org/jabref/gui/EntryTypeView.java b/src/main/java/org/jabref/gui/EntryTypeView.java
index e4f0d11a9c7..476455469d8 100644
--- a/src/main/java/org/jabref/gui/EntryTypeView.java
+++ b/src/main/java/org/jabref/gui/EntryTypeView.java
@@ -39,7 +39,8 @@
/**
* Dialog that prompts the user to choose a type for an entry.
- * Returns null if canceled.
+ *
+ * @return null if canceled
*/
public class EntryTypeView extends BaseDialog {
@@ -90,7 +91,6 @@ public EntryTypeView(BasePanel basePanel, DialogService dialogService, JabRefPre
setEntryTypeForReturnAndClose(Optional.empty());
}
});
-
}
private void addEntriesToPane(FlowPane pane, Collection entries) {
@@ -150,7 +150,6 @@ public void initialize() {
} else {
addEntriesToPane(customPane, customTypes);
}
-
} else {
biblatexTitlePane.setVisible(false);
addEntriesToPane(bibTexPane, BibtexEntryTypeDefinitions.ALL);
@@ -304,5 +303,4 @@ public static String getDescription(EntryType selectedType) {
//CHECKSTYLE:ON
}
-
}
diff --git a/src/main/java/org/jabref/gui/EntryTypeViewModel.java b/src/main/java/org/jabref/gui/EntryTypeViewModel.java
index c3284a74a90..5d24dde230a 100644
--- a/src/main/java/org/jabref/gui/EntryTypeViewModel.java
+++ b/src/main/java/org/jabref/gui/EntryTypeViewModel.java
@@ -71,7 +71,9 @@ public ObjectProperty selectedItemProperty() {
return selectedItemProperty;
}
- public ValidationStatus idFieldValidationStatus() { return idFieldValidator.getValidationStatus(); }
+ public ValidationStatus idFieldValidationStatus() {
+ return idFieldValidator.getValidationStatus();
+ }
public StringProperty idTextProperty() {
return idText;
@@ -101,7 +103,6 @@ public void stopFetching() {
}
private class FetcherWorker extends Task> {
-
private IdBasedFetcher fetcher = null;
private String searchID = "";
@@ -118,7 +119,6 @@ protected Optional call() throws InterruptedException, FetcherExceptio
}
return bibEntry;
}
-
}
public void runFetcherWorker() {
@@ -139,7 +139,6 @@ public void runFetcherWorker() {
searchingProperty.set(false);
fetcherWorker = new FetcherWorker();
-
});
fetcherWorker.setOnSucceeded(evt -> {
@@ -171,7 +170,6 @@ public void runFetcherWorker() {
basePanel.insertEntry(entry);
}
searchSuccesfulProperty.set(true);
-
} else if (StringUtil.isBlank(idText.getValue())) {
dialogService.showWarningDialogAndWait(Localization.lang("Empty search ID"), Localization.lang("The given search ID was empty."));
}
@@ -179,7 +177,6 @@ public void runFetcherWorker() {
focusAndSelectAllProperty.set(true);
searchingProperty().setValue(false);
-
});
}
}
diff --git a/src/main/java/org/jabref/gui/FXDialog.java b/src/main/java/org/jabref/gui/FXDialog.java
index e577568267a..f0d071ae74f 100644
--- a/src/main/java/org/jabref/gui/FXDialog.java
+++ b/src/main/java/org/jabref/gui/FXDialog.java
@@ -15,11 +15,11 @@
/**
* This class provides a super class for all dialogs implemented in JavaFX.
- *
+ *
* To create a custom JavaFX dialog one should create an instance of this class and set a dialog
* pane through the inherited {@link Dialog#setDialogPane(DialogPane)} method.
* The dialog can be shown via {@link Dialog#show()} or {@link Dialog#showAndWait()}.
- *
+ *
* The layout of the pane should be defined in an external fxml file and loaded it via the
* {@link FXMLLoader}.
*/
@@ -78,5 +78,4 @@ private void setDialogIcon(Image image) {
private Stage getDialogWindow() {
return (Stage) getDialogPane().getScene().getWindow();
}
-
}
diff --git a/src/main/java/org/jabref/gui/OpenConsoleAction.java b/src/main/java/org/jabref/gui/OpenConsoleAction.java
index ce634dd73e5..666094c3a4f 100644
--- a/src/main/java/org/jabref/gui/OpenConsoleAction.java
+++ b/src/main/java/org/jabref/gui/OpenConsoleAction.java
@@ -24,11 +24,11 @@ public OpenConsoleAction(StateManager stateManager) {
@Override
public void execute() {
stateManager.getActiveDatabase().flatMap(BibDatabaseContext::getDatabasePath).ifPresent(path -> {
- try {
- JabRefDesktop.openConsole(path.toFile());
- } catch (IOException e) {
- LOGGER.info("Could not open console", e);
- }
+ try {
+ JabRefDesktop.openConsole(path.toFile());
+ } catch (IOException e) {
+ LOGGER.info("Could not open console", e);
+ }
});
}
}
diff --git a/src/main/java/org/jabref/gui/SendAsEMailAction.java b/src/main/java/org/jabref/gui/SendAsEMailAction.java
index 08f412b6a28..15118bea93d 100644
--- a/src/main/java/org/jabref/gui/SendAsEMailAction.java
+++ b/src/main/java/org/jabref/gui/SendAsEMailAction.java
@@ -25,10 +25,10 @@
import org.slf4j.LoggerFactory;
/**
- * Sends the selected entry as email - by Oliver Kopp
- *
+ * Sends the selected entry as email
+ *
* It uses the mailto:-mechanism
- *
+ *
* Microsoft Outlook does not support attachments via mailto
* Therefore, the folder(s), where the file(s) belonging to the entry are stored,
* are opened. This feature is disabled by default and can be switched on at
diff --git a/src/main/java/org/jabref/gui/SidePaneComponent.java b/src/main/java/org/jabref/gui/SidePaneComponent.java
index 603a1bb1407..91f8dfffb95 100644
--- a/src/main/java/org/jabref/gui/SidePaneComponent.java
+++ b/src/main/java/org/jabref/gui/SidePaneComponent.java
@@ -30,7 +30,6 @@ public SidePaneComponent(SidePaneManager manager, JabRefIcon icon, String title)
this.icon = icon;
this.title = title;
this.toggleCommand = new ToggleCommand(this);
-
}
protected void hide() {
diff --git a/src/main/java/org/jabref/gui/StateManager.java b/src/main/java/org/jabref/gui/StateManager.java
index 235a49ec4de..2fc7fc532b0 100644
--- a/src/main/java/org/jabref/gui/StateManager.java
+++ b/src/main/java/org/jabref/gui/StateManager.java
@@ -29,11 +29,14 @@
/**
* This class manages the GUI-state of JabRef, including:
- * - currently selected database
- * - currently selected group
- * - active search
- * - active number of search results
- * - focus owner
+ *
+ *
+ *
currently selected database
+ *
currently selected group
+ *
active search
+ *
active number of search results
+ *
focus owner
+ *
*/
public class StateManager {
@@ -124,9 +127,13 @@ public void setSearchQuery(SearchQuery searchQuery) {
activeSearchQuery.setValue(Optional.of(searchQuery));
}
- public OptionalObjectProperty focusOwnerProperty() { return focusOwner; }
+ public OptionalObjectProperty focusOwnerProperty() {
+ return focusOwner;
+ }
- public Optional getFocusOwner() { return focusOwner.get(); }
+ public Optional getFocusOwner() {
+ return focusOwner.get();
+ }
public ObservableList> getBackgroundTasks() {
return backgroundTasks;
diff --git a/src/main/java/org/jabref/gui/actions/ActionFactory.java b/src/main/java/org/jabref/gui/actions/ActionFactory.java
index 18ea69c745a..be72a1e7e40 100644
--- a/src/main/java/org/jabref/gui/actions/ActionFactory.java
+++ b/src/main/java/org/jabref/gui/actions/ActionFactory.java
@@ -140,7 +140,7 @@ public Button createIconButton(Action action, Command command) {
public ButtonBase configureIconButton(Action action, Command command, ButtonBase button) {
ActionUtils.configureButton(
- new JabRefAction(action, command, keyBindingRepository, Sources.FromButton),
+ new JabRefAction(action, command, keyBindingRepository, Sources.FromButton),
button,
ActionUtils.ActionTextBehavior.HIDE);
diff --git a/src/main/java/org/jabref/gui/actions/JabRefAction.java b/src/main/java/org/jabref/gui/actions/JabRefAction.java
index 4a7aefcd4aa..c017c979e06 100644
--- a/src/main/java/org/jabref/gui/actions/JabRefAction.java
+++ b/src/main/java/org/jabref/gui/actions/JabRefAction.java
@@ -31,6 +31,7 @@ public JabRefAction(Action action, Command command, KeyBindingRepository keyBind
/**
* especially for the track execute when the action run the same function but from different source.
+ *
* @param source is a string contains the source, for example "button"
*/
public JabRefAction(Action action, Command command, KeyBindingRepository keyBindingRepository, Sources source) {
diff --git a/src/main/java/org/jabref/gui/actions/Sources.java b/src/main/java/org/jabref/gui/actions/Sources.java
index 55110553f65..48a3153f049 100644
--- a/src/main/java/org/jabref/gui/actions/Sources.java
+++ b/src/main/java/org/jabref/gui/actions/Sources.java
@@ -3,5 +3,4 @@
public enum Sources {
FromButton,
FromMenu
-
}
diff --git a/src/main/java/org/jabref/gui/actions/StandardActions.java b/src/main/java/org/jabref/gui/actions/StandardActions.java
index 65900dac2c9..df87f1b7e04 100644
--- a/src/main/java/org/jabref/gui/actions/StandardActions.java
+++ b/src/main/java/org/jabref/gui/actions/StandardActions.java
@@ -159,7 +159,6 @@ public enum StandardActions implements Action {
SEARCH_FOR_UPDATES(Localization.lang("Check for updates")),
ABOUT(Localization.lang("About JabRef"), Localization.lang("About JabRef"));
-
private final String text;
private final String description;
private final Optional icon;
diff --git a/src/main/java/org/jabref/gui/autocompleter/AutoCompleteFirstNameMode.java b/src/main/java/org/jabref/gui/autocompleter/AutoCompleteFirstNameMode.java
index 30543681808..c2acbd3647e 100644
--- a/src/main/java/org/jabref/gui/autocompleter/AutoCompleteFirstNameMode.java
+++ b/src/main/java/org/jabref/gui/autocompleter/AutoCompleteFirstNameMode.java
@@ -1,9 +1,11 @@
package org.jabref.gui.autocompleter;
/**
- * For "ONLY_FULL", the auto completer returns the full name, e.g. "Smith, Bob"
- * For "ONLY_ABBREVIATED", the auto completer returns the first name abbreviated, e.g. "Smith, B."
- * For "BOTH", the auto completer returns both versions.
+ *
+ *
For "ONLY_FULL", the auto completer returns the full name, e.g. "Smith, Bob"
+ *
For "ONLY_ABBREVIATED", the auto completer returns the first name abbreviated, e.g. "Smith, B."
+ *
For "BOTH", the auto completer returns both versions.
+ *
*/
public enum AutoCompleteFirstNameMode {
ONLY_FULL,
diff --git a/src/main/java/org/jabref/gui/autocompleter/AutoCompletePreferences.java b/src/main/java/org/jabref/gui/autocompleter/AutoCompletePreferences.java
index 99ba956eb46..0b9aace0f00 100644
--- a/src/main/java/org/jabref/gui/autocompleter/AutoCompletePreferences.java
+++ b/src/main/java/org/jabref/gui/autocompleter/AutoCompletePreferences.java
@@ -37,10 +37,13 @@ public AutoCompleteFirstNameMode getFirstNameMode() {
return firstNameMode;
}
- public NameFormat getNameFormat() { return nameFormat; }
+ public NameFormat getNameFormat() {
+ return nameFormat;
+ }
/**
* Returns the list of fields for which autocomplete is enabled
+ *
* @return List of field names
*/
public Set getCompleteFields() {
diff --git a/src/main/java/org/jabref/gui/auximport/FromAuxDialog.java b/src/main/java/org/jabref/gui/auximport/FromAuxDialog.java
index 7db6fe77f8c..8584b06785b 100644
--- a/src/main/java/org/jabref/gui/auximport/FromAuxDialog.java
+++ b/src/main/java/org/jabref/gui/auximport/FromAuxDialog.java
@@ -98,5 +98,4 @@ private void browseButtonClicked() {
.withInitialDirectory(Globals.prefs.get(JabRefPreferences.WORKING_DIRECTORY)).build();
dialogService.showFileOpenDialog(fileDialogConfiguration).ifPresent(file -> auxFileField.setText(file.toAbsolutePath().toString()));
}
-
}
diff --git a/src/main/java/org/jabref/gui/bibtexextractor/BibtexExtractorViewModel.java b/src/main/java/org/jabref/gui/bibtexextractor/BibtexExtractorViewModel.java
index f69dfd51675..1bf6ea2cd46 100644
--- a/src/main/java/org/jabref/gui/bibtexextractor/BibtexExtractorViewModel.java
+++ b/src/main/java/org/jabref/gui/bibtexextractor/BibtexExtractorViewModel.java
@@ -57,14 +57,14 @@ public StringProperty inputTextProperty() {
public void startParsing() {
BackgroundTask.wrap(() -> currentCitationfetcher.performSearch(inputTextProperty.getValue()))
- .onRunning(() -> dialogService.notify(Localization.lang("Your text is being parsed...")))
- .onSuccess(parsedEntries -> {
- dialogService.notify(Localization.lang("%0 entries were parsed from your query.", String.valueOf(parsedEntries.size())));
- importHandler.importEntries(parsedEntries);
- for (BibEntry bibEntry : parsedEntries) {
- trackNewEntry(bibEntry);
- }
- }).executeWith(taskExecutor);
+ .onRunning(() -> dialogService.notify(Localization.lang("Your text is being parsed...")))
+ .onSuccess(parsedEntries -> {
+ dialogService.notify(Localization.lang("%0 entries were parsed from your query.", String.valueOf(parsedEntries.size())));
+ importHandler.importEntries(parsedEntries);
+ for (BibEntry bibEntry : parsedEntries) {
+ trackNewEntry(bibEntry);
+ }
+ }).executeWith(taskExecutor);
}
private void trackNewEntry(BibEntry bibEntry) {
diff --git a/src/main/java/org/jabref/gui/bibtexextractor/ExtractBibtexDialog.fxml b/src/main/java/org/jabref/gui/bibtexextractor/ExtractBibtexDialog.fxml
index d2182cbaf9c..eaad07b1bb8 100644
--- a/src/main/java/org/jabref/gui/bibtexextractor/ExtractBibtexDialog.fxml
+++ b/src/main/java/org/jabref/gui/bibtexextractor/ExtractBibtexDialog.fxml
@@ -3,18 +3,16 @@
-
-
-
-
-
+
+
+
-
+
diff --git a/src/main/java/org/jabref/gui/bibtexkeypattern/BibtexKeyPatternAction.java b/src/main/java/org/jabref/gui/bibtexkeypattern/BibtexKeyPatternAction.java
index 4564ea7b83b..6875e350836 100644
--- a/src/main/java/org/jabref/gui/bibtexkeypattern/BibtexKeyPatternAction.java
+++ b/src/main/java/org/jabref/gui/bibtexkeypattern/BibtexKeyPatternAction.java
@@ -18,6 +18,6 @@ public BibtexKeyPatternAction(JabRefFrame frame, StateManager stateManager) {
@Override
public void execute() {
- new BibtexKeyPatternDialog(frame.getCurrentBasePanel()).showAndWait();
+ new BibtexKeyPatternDialog(frame.getCurrentBasePanel()).showAndWait();
}
}
diff --git a/src/main/java/org/jabref/gui/bibtexkeypattern/BibtexKeyPatternDialog.java b/src/main/java/org/jabref/gui/bibtexkeypattern/BibtexKeyPatternDialog.java
index b6f7c913d66..d73a0682ae3 100644
--- a/src/main/java/org/jabref/gui/bibtexkeypattern/BibtexKeyPatternDialog.java
+++ b/src/main/java/org/jabref/gui/bibtexkeypattern/BibtexKeyPatternDialog.java
@@ -61,5 +61,4 @@ private void init() {
} */
}
-
}
diff --git a/src/main/java/org/jabref/gui/bibtexkeypattern/GenerateBibtexKeyAction.java b/src/main/java/org/jabref/gui/bibtexkeypattern/GenerateBibtexKeyAction.java
index d0697b31c6a..246d672650d 100644
--- a/src/main/java/org/jabref/gui/bibtexkeypattern/GenerateBibtexKeyAction.java
+++ b/src/main/java/org/jabref/gui/bibtexkeypattern/GenerateBibtexKeyAction.java
@@ -53,13 +53,12 @@ public void execute() {
public static boolean confirmOverwriteKeys(DialogService dialogService) {
if (Globals.prefs.getBoolean(JabRefPreferences.WARN_BEFORE_OVERWRITING_KEY)) {
return dialogService.showConfirmationDialogWithOptOutAndWait(
- Localization.lang("Overwrite keys"),
- Localization.lang("One or more keys will be overwritten. Continue?"),
- Localization.lang("Overwrite keys"),
- Localization.lang("Cancel"),
- Localization.lang("Disable this confirmation dialog"),
- optOut -> Globals.prefs.putBoolean(JabRefPreferences.WARN_BEFORE_OVERWRITING_KEY, !optOut));
-
+ Localization.lang("Overwrite keys"),
+ Localization.lang("One or more keys will be overwritten. Continue?"),
+ Localization.lang("Overwrite keys"),
+ Localization.lang("Cancel"),
+ Localization.lang("Disable this confirmation dialog"),
+ optOut -> Globals.prefs.putBoolean(JabRefPreferences.WARN_BEFORE_OVERWRITING_KEY, !optOut));
} else {
// Always overwrite keys by default
return true;
@@ -109,6 +108,6 @@ private void generateKeys() {
private String formatOutputMessage(String start, int count) {
return String.format("%s %d %s.", start, count,
- (count > 1 ? Localization.lang("entries") : Localization.lang("entry")));
+ (count > 1 ? Localization.lang("entries") : Localization.lang("entry")));
}
}
diff --git a/src/main/java/org/jabref/gui/collab/ChangeDisplayDialog.java b/src/main/java/org/jabref/gui/collab/ChangeDisplayDialog.java
index 1eba9b1c247..d5adf8673ed 100644
--- a/src/main/java/org/jabref/gui/collab/ChangeDisplayDialog.java
+++ b/src/main/java/org/jabref/gui/collab/ChangeDisplayDialog.java
@@ -55,8 +55,8 @@ public ChangeDisplayDialog(BibDatabaseContext database, List {
if (button == dismissChanges) {
@@ -96,7 +96,6 @@ public ChangeDisplayDialog(BibDatabaseContext database, List fileMonitor.removeListener(file, this));
}
-
}
diff --git a/src/main/java/org/jabref/gui/collab/DatabaseChangeViewModel.java b/src/main/java/org/jabref/gui/collab/DatabaseChangeViewModel.java
index 5665c47caf3..bdc7dead217 100644
--- a/src/main/java/org/jabref/gui/collab/DatabaseChangeViewModel.java
+++ b/src/main/java/org/jabref/gui/collab/DatabaseChangeViewModel.java
@@ -39,16 +39,16 @@ public void setAccepted(boolean accepted) {
/**
* This method returns a {@link Node} detailing the nature and look of the change, e.g. how it is displayed
+ *
* @return Node the Node with the layout of the change
*/
public abstract Node description();
/**
- * Performs the change. This method is responsible for adding a proper undo edit to
- * the NamedCompound, so the change can be undone.
+ * Performs the change. This method is responsible for adding a proper undo edit to the NamedCompound, so the change can be undone.
+ *
* @param database the database that should be modified accordingly.
* @param undoEdit NamedCompound The compound to hold the undo edits.
*/
public abstract void makeChange(BibDatabaseContext database, NamedCompound undoEdit);
-
}
diff --git a/src/main/java/org/jabref/gui/collab/EntryChangeViewModel.java b/src/main/java/org/jabref/gui/collab/EntryChangeViewModel.java
index a7de6536a1e..cc303b27178 100644
--- a/src/main/java/org/jabref/gui/collab/EntryChangeViewModel.java
+++ b/src/main/java/org/jabref/gui/collab/EntryChangeViewModel.java
@@ -31,7 +31,7 @@ public EntryChangeViewModel(BibEntry entry, BibEntry newEntry) {
}
/**
- * We override this here to select the radio buttons accordingly
+ * We override this here to select the radio buttons accordingly
*/
@Override
public void setAccepted(boolean accepted) {
diff --git a/src/main/java/org/jabref/gui/collab/EntryDeleteChangeViewModel.java b/src/main/java/org/jabref/gui/collab/EntryDeleteChangeViewModel.java
index 52553eeec3a..4ffdedf3575 100644
--- a/src/main/java/org/jabref/gui/collab/EntryDeleteChangeViewModel.java
+++ b/src/main/java/org/jabref/gui/collab/EntryDeleteChangeViewModel.java
@@ -23,8 +23,8 @@ public EntryDeleteChangeViewModel(BibEntry entry) {
super(Localization.lang("Deleted entry"));
this.name = entry.getCiteKeyOptional()
- .map(key -> Localization.lang("Deleted entry") + ": '" + key + '\'')
- .orElse(Localization.lang("Deleted entry"));
+ .map(key -> Localization.lang("Deleted entry") + ": '" + key + '\'')
+ .orElse(Localization.lang("Deleted entry"));
this.entry = entry;
}
diff --git a/src/main/java/org/jabref/gui/collab/GroupChangeViewModel.java b/src/main/java/org/jabref/gui/collab/GroupChangeViewModel.java
index e6b75feaa38..d907a04db08 100644
--- a/src/main/java/org/jabref/gui/collab/GroupChangeViewModel.java
+++ b/src/main/java/org/jabref/gui/collab/GroupChangeViewModel.java
@@ -52,6 +52,5 @@ public Node description() {
return new Label(toString() + '.'
+ (changedGroups == null ? "" : ' ' + Localization
.lang("Accepting the change replaces the complete groups tree with the externally modified groups tree.")));
-
}
}
diff --git a/src/main/java/org/jabref/gui/collab/StringAddChangeViewModel.java b/src/main/java/org/jabref/gui/collab/StringAddChangeViewModel.java
index f22535b875b..8ad0c7f4e2b 100644
--- a/src/main/java/org/jabref/gui/collab/StringAddChangeViewModel.java
+++ b/src/main/java/org/jabref/gui/collab/StringAddChangeViewModel.java
@@ -46,5 +46,4 @@ public Node description() {
);
return container;
}
-
}
diff --git a/src/main/java/org/jabref/gui/collab/StringChangeViewModel.java b/src/main/java/org/jabref/gui/collab/StringChangeViewModel.java
index b81df8244eb..5747a815a47 100644
--- a/src/main/java/org/jabref/gui/collab/StringChangeViewModel.java
+++ b/src/main/java/org/jabref/gui/collab/StringChangeViewModel.java
@@ -50,5 +50,4 @@ public Node description() {
return container;
}
-
}
diff --git a/src/main/java/org/jabref/gui/collab/StringNameChangeViewModel.java b/src/main/java/org/jabref/gui/collab/StringNameChangeViewModel.java
index e70315cd44e..48a1c473322 100644
--- a/src/main/java/org/jabref/gui/collab/StringNameChangeViewModel.java
+++ b/src/main/java/org/jabref/gui/collab/StringNameChangeViewModel.java
@@ -44,5 +44,4 @@ public void makeChange(BibDatabaseContext database, NamedCompound undoEdit) {
public Node description() {
return new Label(newString.getName() + " : " + string.getContent());
}
-
}
diff --git a/src/main/java/org/jabref/gui/collab/StringRemoveChangeViewModel.java b/src/main/java/org/jabref/gui/collab/StringRemoveChangeViewModel.java
index 71629a34387..3c64138171f 100644
--- a/src/main/java/org/jabref/gui/collab/StringRemoveChangeViewModel.java
+++ b/src/main/java/org/jabref/gui/collab/StringRemoveChangeViewModel.java
@@ -44,5 +44,4 @@ public Node description() {
);
return container;
}
-
}
diff --git a/src/main/java/org/jabref/gui/commonfxcontrols/BibtexKeyPatternPanel.fxml b/src/main/java/org/jabref/gui/commonfxcontrols/BibtexKeyPatternPanel.fxml
index 0031e6a1fd4..861cec5714b 100644
--- a/src/main/java/org/jabref/gui/commonfxcontrols/BibtexKeyPatternPanel.fxml
+++ b/src/main/java/org/jabref/gui/commonfxcontrols/BibtexKeyPatternPanel.fxml
@@ -2,7 +2,6 @@
-
diff --git a/src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanel.fxml b/src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanel.fxml
index cecf5153b6b..965166df83d 100644
--- a/src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanel.fxml
+++ b/src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanel.fxml
@@ -1,19 +1,15 @@
-
-
-
-
diff --git a/src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanel.java b/src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanel.java
index 5f6e1e064b1..2c2762fc5d8 100644
--- a/src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanel.java
+++ b/src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanel.java
@@ -75,9 +75,9 @@ private void setupTable() {
viewModel.selectedCleanupProperty().setValue(cleanupsList.getSelectionModel());
cleanupsList.setOnKeyPressed(event -> {
- if (event.getCode() == KeyCode.DELETE) {
- viewModel.removeCleanup(cleanupsList.getSelectionModel().getSelectedItem());
- }
+ if (event.getCode() == KeyCode.DELETE) {
+ viewModel.removeCleanup(cleanupsList.getSelectionModel().getSelectedItem());
+ }
});
}
@@ -87,10 +87,10 @@ private void setupCombos() {
.install(addableFields);
addableFields.setConverter(FieldsUtil.fieldStringConverter);
addableFields.setOnKeyPressed(event -> {
- if (event.getCode() == KeyCode.TAB || event.getCode() == KeyCode.ENTER) {
- addableFormatters.requestFocus();
- event.consume();
- }
+ if (event.getCode() == KeyCode.TAB || event.getCode() == KeyCode.ENTER) {
+ addableFormatters.requestFocus();
+ event.consume();
+ }
});
new ViewModelListCellFactory()
@@ -98,10 +98,10 @@ private void setupCombos() {
.withStringTooltip(Formatter::getDescription)
.install(addableFormatters);
addableFormatters.setOnKeyPressed(event -> {
- if (event.getCode() == KeyCode.ENTER) {
- viewModel.addCleanup();
- event.consume();
- }
+ if (event.getCode() == KeyCode.ENTER) {
+ viewModel.addCleanup();
+ event.consume();
+ }
});
}
@@ -129,7 +129,11 @@ private void addCleanup() {
viewModel.addCleanup();
}
- public BooleanProperty cleanupsDisableProperty() { return viewModel.cleanupsDisableProperty(); }
+ public BooleanProperty cleanupsDisableProperty() {
+ return viewModel.cleanupsDisableProperty();
+ }
- public ListProperty cleanupsProperty() { return viewModel.cleanupsListProperty(); }
+ public ListProperty cleanupsProperty() {
+ return viewModel.cleanupsListProperty();
+ }
}
diff --git a/src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanelViewModel.java b/src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanelViewModel.java
index 86705892e2e..24258baa7ac 100644
--- a/src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanelViewModel.java
+++ b/src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanelViewModel.java
@@ -62,17 +62,31 @@ public void removeCleanup(FieldFormatterCleanup cleanup) {
cleanupsListProperty.remove(cleanup);
}
- public BooleanProperty cleanupsDisableProperty() { return cleanupsDisableProperty; }
+ public BooleanProperty cleanupsDisableProperty() {
+ return cleanupsDisableProperty;
+ }
- public ListProperty cleanupsListProperty() { return cleanupsListProperty; }
+ public ListProperty cleanupsListProperty() {
+ return cleanupsListProperty;
+ }
- public ObjectProperty> selectedCleanupProperty() { return selectedCleanupProperty; }
+ public ObjectProperty> selectedCleanupProperty() {
+ return selectedCleanupProperty;
+ }
- public ListProperty availableFieldsProperty() { return availableFieldsProperty; }
+ public ListProperty availableFieldsProperty() {
+ return availableFieldsProperty;
+ }
- public ObjectProperty selectedFieldProperty() { return selectedFieldProperty; }
+ public ObjectProperty selectedFieldProperty() {
+ return selectedFieldProperty;
+ }
- public ListProperty availableFormattersProperty() { return availableFormattersProperty; }
+ public ListProperty availableFormattersProperty() {
+ return availableFormattersProperty;
+ }
- public ObjectProperty selectedFormatterProperty() { return selectedFormatterProperty; }
+ public ObjectProperty selectedFormatterProperty() {
+ return selectedFormatterProperty;
+ }
}
diff --git a/src/main/java/org/jabref/gui/commonfxcontrols/SaveOrderConfigPanel.fxml b/src/main/java/org/jabref/gui/commonfxcontrols/SaveOrderConfigPanel.fxml
index e0d26cf19d3..b4ce57f91d7 100644
--- a/src/main/java/org/jabref/gui/commonfxcontrols/SaveOrderConfigPanel.fxml
+++ b/src/main/java/org/jabref/gui/commonfxcontrols/SaveOrderConfigPanel.fxml
@@ -9,7 +9,6 @@
-
@@ -27,14 +26,14 @@
-
-
+
+
-
-
-
+
+
+