From 6837164b8a0caf6c6470bede2a8c83fb317fabbc Mon Sep 17 00:00:00 2001
From: Peiqi Yin <60515999+yinpeiqi@users.noreply.github.com>
Date: Tue, 6 Apr 2021 05:15:20 +0800
Subject: [PATCH] Change export to save (#7518)

* fix: change save and export

* fix: remove method changeExportDescriptionToSave

* fix: remove method changeExportDescriptionToSave

* fix: remove unused import
---
 .../gui/commonfxcontrols/SaveOrderConfigPanel.fxml   |  6 +++---
 .../gui/commonfxcontrols/SaveOrderConfigPanel.java   |  7 -------
 .../libraryproperties/LibraryPropertiesDialog.fxml   |  2 +-
 .../LibraryPropertiesDialogView.java                 |  1 -
 src/main/resources/l10n/JabRef_en.properties         | 12 +++---------
 5 files changed, 7 insertions(+), 21 deletions(-)

diff --git a/src/main/java/org/jabref/gui/commonfxcontrols/SaveOrderConfigPanel.fxml b/src/main/java/org/jabref/gui/commonfxcontrols/SaveOrderConfigPanel.fxml
index b4ce57f91d7..a5992d1457e 100644
--- a/src/main/java/org/jabref/gui/commonfxcontrols/SaveOrderConfigPanel.fxml
+++ b/src/main/java/org/jabref/gui/commonfxcontrols/SaveOrderConfigPanel.fxml
@@ -16,12 +16,12 @@
         <ToggleGroup fx:id="saveOrderToggleGroup"/>
     </fx:define>
 
-    <RadioButton fx:id="exportInOriginalOrder" text="%Export entries in their original order"
+    <RadioButton fx:id="exportInOriginalOrder" text="%Keep original order"
                  toggleGroup="$saveOrderToggleGroup"/>
-    <RadioButton fx:id="exportInTableOrder" text="%Export in current table sort order"
+    <RadioButton fx:id="exportInTableOrder" text="%Use current table sort order"
                  toggleGroup="$saveOrderToggleGroup"/>
     <RadioButton fx:id="exportInSpecifiedOrder"
-                 text="%Export entries ordered as specified" toggleGroup="$saveOrderToggleGroup"/>
+                 text="%Use specified order" toggleGroup="$saveOrderToggleGroup"/>
 
     <GridPane hgap="10.0" vgap="4.0">
         <columnConstraints>
diff --git a/src/main/java/org/jabref/gui/commonfxcontrols/SaveOrderConfigPanel.java b/src/main/java/org/jabref/gui/commonfxcontrols/SaveOrderConfigPanel.java
index b3ae2db5549..55bb2b66941 100644
--- a/src/main/java/org/jabref/gui/commonfxcontrols/SaveOrderConfigPanel.java
+++ b/src/main/java/org/jabref/gui/commonfxcontrols/SaveOrderConfigPanel.java
@@ -11,7 +11,6 @@
 
 import org.jabref.gui.util.FieldsUtil;
 import org.jabref.gui.util.ViewModelListCellFactory;
-import org.jabref.logic.l10n.Localization;
 import org.jabref.model.entry.field.Field;
 
 import com.airhacks.afterburner.views.ViewLoader;
@@ -70,12 +69,6 @@ private void initialize() {
         saveTerDesc.selectedProperty().bindBidirectional(viewModel.saveTertiaryDescPropertySelected());
     }
 
-    public void changeExportDescriptionToSave() {
-        exportInOriginalOrder.setText(Localization.lang("Save entries in their original order"));
-        exportInSpecifiedOrder.setText(Localization.lang("Save entries ordered as specified"));
-        exportInTableOrder.setText(Localization.lang("Save in current table sort order"));
-    }
-
     public BooleanProperty saveInOriginalProperty() {
         return viewModel.saveInOriginalProperty();
     }
diff --git a/src/main/java/org/jabref/gui/libraryproperties/LibraryPropertiesDialog.fxml b/src/main/java/org/jabref/gui/libraryproperties/LibraryPropertiesDialog.fxml
index cae304a8e33..a21e814b1e2 100644
--- a/src/main/java/org/jabref/gui/libraryproperties/LibraryPropertiesDialog.fxml
+++ b/src/main/java/org/jabref/gui/libraryproperties/LibraryPropertiesDialog.fxml
@@ -80,7 +80,7 @@
                 <CheckBox fx:id="protect"
                           text="%Refuse to save the library before external changes have been reviewed."/>
 
-                <Label styleClass="sectionHeader" text="%Export sort order"/>
+                <Label styleClass="sectionHeader" text="%Save sort order"/>
                 <SaveOrderConfigPanel fx:id="saveOrderConfigPanel"/>
 
                 <Label styleClass="sectionHeader" text="%Save actions"/>
diff --git a/src/main/java/org/jabref/gui/libraryproperties/LibraryPropertiesDialogView.java b/src/main/java/org/jabref/gui/libraryproperties/LibraryPropertiesDialogView.java
index 0a58302ae75..ae5027555d6 100644
--- a/src/main/java/org/jabref/gui/libraryproperties/LibraryPropertiesDialogView.java
+++ b/src/main/java/org/jabref/gui/libraryproperties/LibraryPropertiesDialogView.java
@@ -79,7 +79,6 @@ private void initialize() {
         protect.disableProperty().bind(viewModel.protectDisableProperty());
         protect.selectedProperty().bindBidirectional(viewModel.libraryProtectedProperty());
 
-        saveOrderConfigPanel.changeExportDescriptionToSave();
         saveOrderConfigPanel.saveInOriginalProperty().bindBidirectional(viewModel.saveInOriginalProperty());
         saveOrderConfigPanel.saveInTableOrderProperty().bindBidirectional(viewModel.saveInTableOrderProperty());
         saveOrderConfigPanel.saveInSpecifiedOrderProperty().bindBidirectional(viewModel.saveInSpecifiedOrderProperty());
diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties
index 6eb511b34cf..e9446f09bbf 100644
--- a/src/main/resources/l10n/JabRef_en.properties
+++ b/src/main/resources/l10n/JabRef_en.properties
@@ -736,8 +736,6 @@ Save\ before\ closing=Save before closing
 Save\ library=Save library
 Save\ library\ as...=Save library as...
 
-Save\ entries\ in\ their\ original\ order=Save entries in their original order
-
 Saved\ selected\ to\ '%0'.=Saved selected to '%0'.
 
 Saving=Saving
@@ -956,10 +954,6 @@ A\ local\ copy\ will\ be\ opened.=A local copy will be opened.
 Autosave\ local\ libraries=Autosave local libraries
 Automatically\ save\ the\ library\ to=Automatically save the library to
 Please\ enter\ a\ valid\ file\ path.=Please enter a valid file path.
-
-
-Export\ in\ current\ table\ sort\ order=Export in current table sort order
-Export\ entries\ in\ their\ original\ order=Export entries in their original order
 Error\ opening\ file\ '%0'.=Error opening file '%0'.
 
 Formatter\ not\ found\:\ %0=Formatter not found: %0
@@ -1196,13 +1190,13 @@ Attention\:\ Password\ is\ stored\ in\ plain\ text\!=Attention: Password is stor
 Clear\ connection\ settings=Clear connection settings
 
 Open\ folder=Open folder
-Export\ entries\ ordered\ as\ specified=Export entries ordered as specified
 Export\ sort\ order=Export sort order
 Save\ sort\ order=Save sort order
 Newline\ separator=Newline separator
 
-Save\ in\ current\ table\ sort\ order=Save in current table sort order
-Save\ entries\ ordered\ as\ specified=Save entries ordered as specified
+Keep\ original\ order=Keep original order
+Use\ current\ table\ sort\ order=Use current table sort order
+Use\ specified\ order=Use specified order
 Show\ extra\ columns=Show extra columns
 Parsing\ error=Parsing error
 illegal\ backslash\ expression=illegal backslash expression