From 794a652b41c429b165fa37153b2479d0118df7d2 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Tue, 10 Mar 2020 10:36:27 +0100 Subject: [PATCH] Checkstyle --- src/main/java/org/jabref/gui/JabRefFrame.java | 4 ++-- .../org/jabref/architecture/TestArchitectureTests.java | 1 - src/test/java/org/jabref/gui/ScreenshotDarkTheme.java | 2 +- src/test/java/org/jabref/gui/Screenshots.java | 10 +++++----- 4 files changed, 8 insertions(+), 9 deletions(-) diff --git a/src/main/java/org/jabref/gui/JabRefFrame.java b/src/main/java/org/jabref/gui/JabRefFrame.java index ebdff681dc2c..0d09379cf085 100644 --- a/src/main/java/org/jabref/gui/JabRefFrame.java +++ b/src/main/java/org/jabref/gui/JabRefFrame.java @@ -146,10 +146,10 @@ */ public class JabRefFrame extends BorderPane { - private static final Logger LOGGER = LoggerFactory.getLogger(JabRefFrame.class); - public static final String FRAME_TITLE = "JabRef"; + private static final Logger LOGGER = LoggerFactory.getLogger(JabRefFrame.class); + private final SplitPane splitPane = new SplitPane(); private final JabRefPreferences prefs = Globals.prefs; private final GlobalSearchBar globalSearchBar = new GlobalSearchBar(this, Globals.stateManager); diff --git a/src/test/java/org/jabref/architecture/TestArchitectureTests.java b/src/test/java/org/jabref/architecture/TestArchitectureTests.java index 2c346aac803a..0e8112c44754 100644 --- a/src/test/java/org/jabref/architecture/TestArchitectureTests.java +++ b/src/test/java/org/jabref/architecture/TestArchitectureTests.java @@ -5,7 +5,6 @@ import java.nio.file.Files; import java.nio.file.Path; import java.nio.file.Paths; -import java.util.ArrayList; import java.util.Collections; import java.util.List; import java.util.function.Predicate; diff --git a/src/test/java/org/jabref/gui/ScreenshotDarkTheme.java b/src/test/java/org/jabref/gui/ScreenshotDarkTheme.java index d956e5c9c291..1563883ebf5b 100644 --- a/src/test/java/org/jabref/gui/ScreenshotDarkTheme.java +++ b/src/test/java/org/jabref/gui/ScreenshotDarkTheme.java @@ -34,7 +34,7 @@ class ScreenshotDarkTheme { private static final Logger LOGGER = LoggerFactory.getLogger(ScreenshotDarkTheme.class); - final static Path root = Path.of("build/screenshots").toAbsolutePath(); + private static final Path ROOT = Path.of("build/screenshots").toAbsolutePath(); @BeforeAll static void createDirectory() throws IOException { diff --git a/src/test/java/org/jabref/gui/Screenshots.java b/src/test/java/org/jabref/gui/Screenshots.java index 4a3859fd86fb..4d2e6d22a284 100644 --- a/src/test/java/org/jabref/gui/Screenshots.java +++ b/src/test/java/org/jabref/gui/Screenshots.java @@ -32,12 +32,12 @@ class Screenshots { private static final Logger LOGGER = LoggerFactory.getLogger(Screenshots.class); - final static Path root = Path.of("build/screenshots").toAbsolutePath(); + private static final Path ROOT = Path.of("build/screenshots").toAbsolutePath(); @BeforeAll static void createDirectory() throws IOException { - if (!Files.exists(root)) { - Files.createDirectory(root); + if (!Files.exists(ROOT)) { + Files.createDirectory(ROOT); } } @@ -65,7 +65,7 @@ public void onStop() { @Order(1) void screenshotMainMenu() { StringBuilder stringBuilder = new StringBuilder(); - DebugUtils.saveScreenshot(() -> root.resolve("main-empty.png"), "").apply(stringBuilder); + DebugUtils.saveScreenshot(() -> ROOT.resolve("main-empty.png"), "").apply(stringBuilder); LOGGER.debug(stringBuilder.toString()); } @@ -79,7 +79,7 @@ void screenshotOpenedDatabase(FxRobot robot) throws Exception { JabRefGUI.getMainFrame().getOpenDatabaseAction().openFile(jabrefAuthorsBib, true); // give database some time load robot.interrupt(100); - DebugUtils.saveScreenshot(() -> root.resolve("opened-database.png"), "").apply(stringBuilder); + DebugUtils.saveScreenshot(() -> ROOT.resolve("opened-database.png"), "").apply(stringBuilder); LOGGER.debug(stringBuilder.toString()); } }