Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add link to themes website #10243

Closed
ghost opened this issue Aug 30, 2023 · 16 comments
Closed

feature request: add link to themes website #10243

ghost opened this issue Aug 30, 2023 · 16 comments
Assignees
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. preferences type: enhancement ui

Comments

@ghost
Copy link

ghost commented Aug 30, 2023

I would like to request a small feature: see screenshot

7f4e0e5cb655b165e34b6eb4011b69cafa0ba817

Reasons:

  • users can easily find the themes website, which they may have not heard of, from within jabref
  • it can attract theme contributors
@Siedlerchr
Copy link
Member

The link should point to themes.jabref.org

@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement labels Sep 1, 2023
@github-project-automation github-project-automation bot moved this to Normal priority in Features & Enhancements Sep 1, 2023
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Sep 1, 2023
@ghost
Copy link
Author

ghost commented Sep 2, 2023

The link should point to themes.jabref.org

Yes I agree!
And the screenshot view can be added on themes.jabref.org too

JabRef/themes.jabref.org#10

@Jaovitosr
Copy link
Contributor

Hello, I hope you're all doing well! I'm a newcomer, and I think I have the required habilites to solve this issue. Could you please confirm whether this issue has already been assigned to someone? If it hasn't it would be a pleasure to contribute to your project!

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@Siedlerchr
Copy link
Member

@Jaovitosr I can assign you. It's free to take.

@Siedlerchr Siedlerchr moved this from Free to take to Reserved in Good First Issues Sep 4, 2023
@Siedlerchr Siedlerchr assigned Siedlerchr and Jaovitosr and unassigned Siedlerchr Sep 4, 2023
@Jaovitosr
Copy link
Contributor

Thank you very much!

@ghost
Copy link
Author

ghost commented Sep 4, 2023

There is also the theme preview website but I'm not a programmer so it's impossible for me to make this.
Maybe if you're interested? All the themes and screenshots are on github.

JabRef/themes.jabref.org#10

@ghost
Copy link
Author

ghost commented Sep 4, 2023

Thank you very much!

Please note this is a screenshot of 5.9 and in 5.10 it's located in the first tabpage of jabref preferences.

@Jaovitosr
Copy link
Contributor

There is also the theme preview website but I'm not a programmer so it's impossible for me to make this. Maybe if you're interested? All the themes and screenshots are on github.

JabRef/themes.jabref.org#10

Ok, I'll check this out! Thanks for the idea!

@Jaovitosr
Copy link
Contributor

Hello, I hope you're doing well! I'm currently working on resolving this issue, and have run into a bit of a roadblock. I'm having trouble locating the specific directory where the file I need to modify is located. I've gone through the project structure, but I'm unable to pinpoint the exact location.
It would be greatly appreciated if you could provide some guidance or clarification on the directory structure or the file's location. Your assistance would be invaluable in helping me move forward with this issue. Thank you in advance for your support!

@ghost
Copy link
Author

ghost commented Sep 5, 2023

I'm not a developer so I can't help :-(
@Siedlerchr help please.

@Jaovitosr
Copy link
Contributor

Hello everyone! I've located the directories I need to modify and have made the necessary changes. However, I'm encountering an issue where every time I click on the button that should open the browser to the 'themes.jabref.org' web page, the application crashes.
I've double-checked my code, and it seems to be correctly launching the web page, but the crash persists. I've also ensured that the URL 'themes.jabref.org' is valid. I'd appreciate any insights or assistance you can provide in troubleshooting this issue. If there are specific logs or error messages you'd like me to share, please let me know, and I'll provide them for further investigation.
Thank you for your help!

@Siedlerchr
Copy link
Member

Hmm can you please open a pull request with you changes? JabRef desktop classes contains methods for opening links

@Jaovitosr
Copy link
Contributor

Hello! I openned a pull request, but this is my first time ever making a contribution... If there are any mistakes in my pull request, I apologize in advance and would appreciate any feedback or guidance to improve.

@taliashark77
Copy link

Has this issue been completed?

@github-project-automation github-project-automation bot moved this from Normal priority to Done in Features & Enhancements Oct 16, 2023
@github-project-automation github-project-automation bot moved this from Reserved to Done in Good First Issues Oct 16, 2023
@ThiloteE
Copy link
Member

@Jaovitosr

Since you asked for feedback, I would like to mention a nice little feature of github:

To ease organizational workflows it is possible to link the pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue, which will close issues automatically, once the pull-request is merged.

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

  • close
  • closes
  • closed
  • fix
  • fixes
  • fixed
  • resolve
  • resolves
  • resolved

If you use a keyword to reference a pull request comment in another pull request, the pull requests will be linked. Merging the referencing pull request also closes the referenced pull request.

The syntax for closing keywords depends on whether the issue is in the same repository as the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. preferences type: enhancement ui
Projects
Archived in project
Archived in project
Development

No branches or pull requests

4 participants