Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make preferences backwards compatible #10940

Open
ColinScarato opened this issue Feb 28, 2024 · 4 comments
Open

Make preferences backwards compatible #10940

ColinScarato opened this issue Feb 28, 2024 · 4 comments
Labels
preferences status: waiting-for-feedback The submitter or other users need to provide more information about the issue

Comments

@ColinScarato
Copy link

ColinScarato commented Feb 28, 2024

Could it be possible to make preferences backwards compatible, from a release to the other?

E.g. <entry key="fetcherCustomKeyUses" value="false;false;false;false;false"/> changed to a different number of values between 5.6 and 5.12. Importing old settings from one version to the other seemed to break the preferences manager: it resulted in no preferences being imported at all.

Changing how preferences are stored/formatted might relate to #8701.

@Siedlerchr
Copy link
Member

Hi,
this should already be the case. There is automatic preferences migration at startup from older versions to newer versions.
e.g. 5.11-> 5.12 -> 5.13
However, it's not possible to import newer preferences (e.g. 5.12 in older JabRef e.g. 5.7)
Do you have an example preferences file? Do you get an exception?
You can also send us your prefs privately if you don't want to post them here

@HoussemNasri HoussemNasri added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label May 6, 2024
@koppor
Copy link
Member

koppor commented May 18, 2024

Related: #11294 (comment) (keyboard shortcuts stopped working and user needed to reset the preferences)

@koppor
Copy link
Member

koppor commented May 18, 2024

@HoussemNasri We need to create a proper test setup. The best with running JabRef versions and UI Tests (e.g., using https://www.qfs.de/produkt/qf-test/windows-testen.html). I mean real "system tests". Tobias argued against them, but we see unknown breaking changes at various places and with system tests we would have noticed that.

We should start with one of us starting a Windows Sandbox. Install JabRef 5.6 there, save preferences. Install current JabRef and check for the issue. Try out multiple settings and see where we have difficulties. It could really be the keyboard shortcuts.

@koppor
Copy link
Member

koppor commented May 18, 2024

Especially issuehttps://github.com//issues/10370 is the most important when talking about preferences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
None yet
Development

No branches or pull requests

4 participants