Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shared database feature #1703

Closed
6 tasks done
koppor opened this issue Aug 9, 2016 · 2 comments
Closed
6 tasks done

Improve shared database feature #1703

koppor opened this issue Aug 9, 2016 · 2 comments
Assignees
Milestone

Comments

@koppor
Copy link
Member

koppor commented Aug 9, 2016

Follow up of #1451

  • Database properties dialog:
    • Do not show "Save sort order" - database sorts arbitrarily 😇
    • Do not show "Database protection" - makes no sense in a shared database setting
  • Session restore: JabRef should open all [shared] tabs after startup
  • Store last used connection in the "open remote database dialog"
  • "open remote database dialog": "Connect" button should be disabled an label change to "Connecting...". Reason: Connection may take longer and pressing the button multiple times leads to error message dialogs. (You know, http://www.freemysqlhosting.net/ latency)
@Siedlerchr
Copy link
Member

Siedlerchr commented Aug 9, 2016

  • Use AssumeTrue(DevEnvironment.isCIServer()) switch to disable database tests locally. Prevents failing tests, if no db is running locally.

@koppor
Copy link
Member Author

koppor commented Aug 9, 2016

Alternative solution: #1705 to make it explicit when to call the database tests. I know that one can also run the tests using the ide, but I would like to keep the consistency with our integration tests. Please follow up at #1705.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants