Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Import/Export preferences dialog with working directory as default #1813

Closed
grimes2 opened this issue Aug 22, 2016 · 15 comments
Closed
Labels
Milestone

Comments

@grimes2
Copy link
Contributor

grimes2 commented Aug 22, 2016

The current default directory is user-dir. I think, the correct place for the xml file is the working directory (or a subdirectory of it). The working directory variable should work now.

Talking about this dialog:
image

@stefan-kolb stefan-kolb added this to the v3.6 milestone Aug 22, 2016
@stefan-kolb
Copy link
Member

@JabRef/developers We got a few different working dirs. Maybe we should discuss if we really need them or just use one working dir for all dialogs:

    public static final String FILE_WORKING_DIRECTORY = "fileWorkingDirectory";
    public static final String IMPORT_WORKING_DIRECTORY = "importWorkingDirectory";
    public static final String EXPORT_WORKING_DIRECTORY = "exportWorkingDirectory";
    public static final String WORKING_DIRECTORY = "workingDirectory";

@stefan-kolb
Copy link
Member

Especially FILE_WORKING_DIRECTORY is debatable. used for external file type application selection and in the file dialog of the general tab of an entry.

@grimes2
Copy link
Contributor Author

grimes2 commented Aug 22, 2016

IMPORT_WORKING_DIRECTORY and EXPORT_WORKING_DIRECTORY are used to remember last used directory. This is ok.
Reason: It is ok to outsource this various format stuff from working directory.

@Siedlerchr
Copy link
Member

Working Directory is clear, it is always the location of the bib file (if not otherwise set).
Yeah, I think File_Working_Directory is confusing, especially for adding a file to an entry. There I would expect to open the dlg in the Working_Directory. However, some may prefer having two different dirs for that. No idea. Ask the users.

@stefan-kolb
Copy link
Member

It's not really about the user right now it's about the concept because it's inconsistent at the moment.

@grimes2
Copy link
Contributor Author

grimes2 commented Aug 23, 2016

My user opinion regarding FILE_WORKING_DIRECTORY: You can remove the variable, text field, browse button in the preferences. And also remove the checkbox below and set WORKING_DIRECTORY as default for the entry editor dialog.
Reason: It is ok to store the supplemental file material with the corresponding bib file.
EDIT: It is complicated. The text field sets the variable FILE_DIRECTORY. This directory is used by "Move file to file directory" in Entry editor > File. This is useful. The checkbox below toggles between WORKING_DIRECTORY and FILE_DIRECTORY or bib-file-specific PDF directory. This is really something for advanced user. Summary: It's better, not to touch the code. Bug: FILE_WORKING_DIRECTORY is set to a full path with file.

@grimes2
Copy link
Contributor Author

grimes2 commented Aug 30, 2016

I want to work on this issue. But I need your ok, that this change from user-dir to working-dir for the preferences xml is useful.

@Siedlerchr
Copy link
Member

@JabRef/developers Any comments on this? From my point of view it's okay to change it to working-dir

@stefan-kolb
Copy link
Member

Issue not closed yet, see my comment on file prefs.

@koppor
Copy link
Member

koppor commented Sep 8, 2016

@grimes2 Where is the text field for FILE_WORKING_DIRECTORY? And the checkbox? I see only the screenshot with Export Preferenes.

In the preferences, I see:

grabbed_20160908-052540

In the context menu of a database, I see:

grabbed_20160908-052617

The different directories are explained at #459 (comment) - IMHO not yet in the documentation

Is it possible that I am on the wrong track? But "checkbox" sounds like GUI.

@grimes2
Copy link
Contributor Author

grimes2 commented Sep 8, 2016

I was wrong. It is the textbox for the FILE_DIRECTORY and the checkbox below (Use the BIB file location as primary file directory) toggles between FILE_DIRECTORY and WORKING_DIRECTORY. This is ok, but I don't know the purpose of FILE_WORKING_DIRECTORY and I doubt it's working properly, because the variable is set to a full path (with file name). It is really confusing. I mixed up the directories.

@stefan-kolb
Copy link
Member

We remove FILE_WORKING_DIRECTORY and use WORKING_DIRECTORY instead.

@koppor
Copy link
Member

koppor commented Sep 13, 2016

@grimes2 Do you mean "Main file directory" and "Use the BIB file location as primary directory"?

@grimes2
Copy link
Contributor Author

grimes2 commented Sep 13, 2016

Yes. I think this layout is not intuitive. Default "Main file directory" should be the working directory. The checkbox "Use the BIB file location as primary directory" should be replaced by radio buttons: a) Use custom main file directory, b) Use BIB file directory. (This are just some ideas)

@grimes2
Copy link
Contributor Author

grimes2 commented Sep 13, 2016

@stefan-kolb Can you explain? I thought, FILE_WORKING_DIRECTORY is essentially the same as FILE_DIRECTORY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants