Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value delimiters: configuration of using quotes or force always curly braces? #214

Closed
koppor opened this issue Oct 6, 2015 · 5 comments
Closed

Comments

@koppor
Copy link
Member

koppor commented Oct 6, 2015

@kubovy introduced configration of value delimiters in 4f9fb0b, @mortenalver removed the configuration option in 74e7296. I remember that there was an issue regarding escaping the " in Strings delimited with "" and therefore the choice was just disabled.

The user had the choice between "..." and {...} as value delimiters. Currently, only {...} are used.

Regarding our discussion at #116 and that " is really seldomly used in the wild, I would propose to remove net.sf.jabref.JabRefPreferences.VALUE_DELIMITERS2 and all transitive dependencies.

@stefan-kolb
Copy link
Member

👍

@simonharrer
Copy link
Contributor

👍 for deleting code :-)

@oscargus
Copy link
Contributor

oscargus commented Oct 6, 2015

See this for a discussion. The only examples given support that {...} is the better choice (or at least not worse).

However, it can be noted that Tame the BeaST -- The B to X of BibTeX uses "..." in all their examples (except the one talking about the two alternatives).

Google Scholar generates entries with {...}.

Still, I guess that it would be good if JabRef can read .bib-files that use "..." and possibly warn that they will be written back using {...}.

I would vote for completely removing support for "..." too. I do not see any use case where it would be beneficial to use "..." compared to {...}.

@kubovy
Copy link
Contributor

kubovy commented Oct 14, 2015

👍

@lenhard
Copy link
Member

lenhard commented Jan 26, 2016

Parsing works with quotes instead of curly braces as well (see the test implemented in 4a93387).

I think there is a consensus here, so I am closing this issue.

@lenhard lenhard closed this as completed Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants