Preserve % sign inside BibTeX fields via cleanup #2375

stefan-kolb · 2016-12-13T13:01:05Z

Resolves #2011
You can now use LateXCleanup inside quality->cleanups to escape % to \%

lenhard · 2016-12-13T13:35:38Z

How about a Changelog entry and we are ready to go :)

lenhard · 2016-12-13T14:09:15Z

CHANGELOG.md

@@ -25,6 +25,9 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 - Replaces manual thread management with cached thread pool
 - Files can now be moved to subfolders named by a custom format pattern, e.g., based on `entrytype`.
  The pattern can be specified in the settings like the filename pattern. [#1092](https://github.com/JabRef/jabref/issues/1092)
+


Why are there two additional newlines here?

To avoid merge conflicts with other PRs.

Ok, fine. I would merge this right now, but maybe we should give @bernhard-kleine at least time until the release tomorrow, before we merge and delete the branch.

We should not forget to merge it before the release, though.

tobiasdiez

Just nitpicking - can be merged afterwards.

tobiasdiez · 2016-12-15T11:25:00Z

CHANGELOG.md

@@ -25,6 +25,9 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 - Replaces manual thread management with cached thread pool
 - Files can now be moved to subfolders named by a custom format pattern, e.g., based on `entrytype`.
  The pattern can be specified in the settings like the filename pattern. [#1092](https://github.com/JabRef/jabref/issues/1092)
+
+
+- [#2375](https://github.com/JabRef/jabref/issues/2375) LaTeXCleanup action does now preserve % signs inside BibTeX fields


I would change "preserve" to "escape", and, moreover, "LaTeXCleanup" is not an English word 😄

Siedlerchr · 2016-12-15T11:36:04Z

Put ruhe Latex cleanup in Single quotes as it is a command in JabRef

bernhard-kleine · 2016-12-18T11:26:23Z

When importing via the firefox plugin the percent sign are excaped. Importing via the medline websearch they are not. I do not find any mentioning in the cleanup dialogue of percent sign changed to % signs.

JabRef 3.8
windows 7 6.1 amd64
Java 1.8.0_66

Siedlerchr · 2016-12-18T13:44:01Z

@bernhard-kleine The cleanup is not done automatically.
You should use Cleanup->and then select the field you want to cleanup, e.g. abstract together with LaTeX Cleanup

bernhard-kleine · 2016-12-18T14:07:59Z

I updated to JabRef 3.8 today, i choose the 64bit version.
I took a new database.
I imported via the medline web search PMID 27697972.
The abstract has unescaped percent signs. Therefore, I went to quality->cleanup and as the abstract field is already selected I checked all the entries in the field to the right but can not find percent sign. Latex cleanup did not find anything to cleanup. What do I miss?

bernhard-kleine · 2016-12-18T14:10:28Z

I had to add it first and then run the cleanup. Sorry for the noise!

j0hannes · 2017-03-20T10:20:13Z

I added LaTeX cleanup for the abstract field. Still, percent sign are saved as they are which leads to errors when running biber. In case the percent sign is escaped, jabref removes the backslash when saving.

Siedlerchr · 2017-03-20T10:30:34Z

@j0hannes This has been fixed with #2521
Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you.

j0hannes · 2017-03-20T11:33:51Z

@Siedlerchr I tried version 4.0 and it seems to be quite unstable; I had to force quit the application each time as it was hanging. Before crashing it destroyed some of the keys, so I'm going back to 3.8.2 now. Is there any other way to address the percent problem?

Siedlerchr · 2017-03-20T12:34:15Z

@j0hannes Could you please open a new issue for the problems you encounter with the 4.0.0 version in detail?
E.g. Operation system, any errors in/from the log?

You could manually escape the %-signs by adding a Backslash \ before it. That works.
You could simply search for the %-sign to see all problematic entries and then escape them manually

bernhard-kleine · 2017-03-20T12:45:00Z

I have raised issues for the backslash and the % sign before. My problems are gone with Version 4.0.0 using Quality->cleanup entries-> and adding abstract: Latex cleanup the the Run field formatter: before clicking OK. The errors due not excaped % signs turn out to be tiresome, since the error message for example in texstudio plus latexmk are not direct, only by checking the log you know that a % sign was not escaped. Am 20.03.2017 um 13:34 schrieb Christoph:

…

@j0hannes <https://github.com/j0hannes> Could you please open a new issue for the problems you encounter with the 4.0.0 version in detail? E.g. Operation system, any errors in/from the log? You could manually escape the %-signs by adding a Backslash \ before it. That works. You could simply search for the %-sign to see all problematic entries and then escape them manually — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2375 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIyh51Vqm2pRk83pefo3h891xvpSBSOCks5rnnJIgaJpZM4LLtFh>.

-- spitzhalde9 D-79853 lenzkirch bernhard.kleine@gmx.net www.b-kleine.com, www.urseetal.net - thunderbird mit enigmail GPG schlüssel: D5257409 fingerprint: 08 B7 F8 70 22 7A FC C1 15 49 CA A6 C7 6F A0 2E D5 25 74 09

j0hannes · 2017-03-20T12:55:26Z

After changing my bib file manually, version 4.0 is not crashing anymore. Still, it modifies all my citation keys and I don't find any way to stop it.

Siedlerchr · 2017-03-20T13:42:23Z

@j0hannes Did you run a cleanup operation or a save action? Did you check the keypattern settings?
I would suggest opening a new issue, if this problem still exists

j0hannes · 2017-03-20T13:53:42Z

@Siedlerchr No, it happens right when typing, loading or after inspecting manual changes to the bib file. When typing keys are changed when the focus moves to a different field.

j0hannes · 2017-04-05T19:52:35Z

I can confirm that the problem still persists with "abstract: LaTeX cleanup" enabled in version 4.0.0-dev. Every time I enter %, it is immediately changed to % and % ends up as % in the bib file which causes LaTeX to fail.

Siedlerchr · 2017-04-06T13:05:40Z

I can not reproduce this. % sign is correctly escaped (and only once) to \%
Using Latex Cleanup for abstract.

j0hannes · 2017-04-06T16:27:30Z

It certainly was caused by the LaTeX to Unicode filter.

Resolves #2011 Preserve % sign inside BibTeX fields via cleanup

daa54c3

stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 13, 2016

Siedlerchr approved these changes Dec 13, 2016

View reviewed changes

Changelog

81545e5

lenhard reviewed Dec 13, 2016

View reviewed changes

stefan-kolb added this to the v3.8 milestone Dec 13, 2016

tobiasdiez requested changes Dec 15, 2016

View reviewed changes

tobiasdiez removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 15, 2016

stefan-kolb added 2 commits December 15, 2016 13:22

Update CHANGELOG.md

27a7eba

Merge branch 'master' into preserve-percent-sign

d4f388f

koppor merged commit 832417f into master Dec 15, 2016

koppor deleted the preserve-percent-sign branch December 15, 2016 14:37

j0hannes mentioned this pull request Apr 5, 2017

Hyphenation is undone by Jabref #2712

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preserve % sign inside BibTeX fields via cleanup #2375

Preserve % sign inside BibTeX fields via cleanup #2375

stefan-kolb commented Dec 13, 2016 •

edited

Loading

lenhard commented Dec 13, 2016

lenhard Dec 13, 2016

stefan-kolb Dec 13, 2016

lenhard Dec 13, 2016

tobiasdiez left a comment

tobiasdiez Dec 15, 2016

Siedlerchr commented Dec 15, 2016 via email •

edited by koppor

Loading

bernhard-kleine commented Dec 18, 2016 •

edited

Loading

Siedlerchr commented Dec 18, 2016 •

edited

Loading

bernhard-kleine commented Dec 18, 2016

bernhard-kleine commented Dec 18, 2016

j0hannes commented Mar 20, 2017

Siedlerchr commented Mar 20, 2017

j0hannes commented Mar 20, 2017

Siedlerchr commented Mar 20, 2017

bernhard-kleine commented Mar 20, 2017 via email

j0hannes commented Mar 20, 2017

Siedlerchr commented Mar 20, 2017

j0hannes commented Mar 20, 2017

j0hannes commented Apr 5, 2017

Siedlerchr commented Apr 6, 2017

j0hannes commented Apr 6, 2017

Preserve % sign inside BibTeX fields via cleanup #2375

Preserve % sign inside BibTeX fields via cleanup #2375

Conversation

stefan-kolb commented Dec 13, 2016 • edited Loading

lenhard commented Dec 13, 2016

lenhard Dec 13, 2016

Choose a reason for hiding this comment

stefan-kolb Dec 13, 2016

Choose a reason for hiding this comment

lenhard Dec 13, 2016

Choose a reason for hiding this comment

tobiasdiez left a comment

Choose a reason for hiding this comment

tobiasdiez Dec 15, 2016

Choose a reason for hiding this comment

Siedlerchr commented Dec 15, 2016 via email • edited by koppor Loading

bernhard-kleine commented Dec 18, 2016 • edited Loading

Siedlerchr commented Dec 18, 2016 • edited Loading

bernhard-kleine commented Dec 18, 2016

bernhard-kleine commented Dec 18, 2016

j0hannes commented Mar 20, 2017

Siedlerchr commented Mar 20, 2017

j0hannes commented Mar 20, 2017

Siedlerchr commented Mar 20, 2017

bernhard-kleine commented Mar 20, 2017 via email

j0hannes commented Mar 20, 2017

Siedlerchr commented Mar 20, 2017

j0hannes commented Mar 20, 2017

j0hannes commented Apr 5, 2017

Siedlerchr commented Apr 6, 2017

j0hannes commented Apr 6, 2017

stefan-kolb commented Dec 13, 2016 •

edited

Loading

Siedlerchr commented Dec 15, 2016 via email •

edited by koppor

Loading

bernhard-kleine commented Dec 18, 2016 •

edited

Loading

Siedlerchr commented Dec 18, 2016 •

edited

Loading