Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run "Abbreviate journal names" in parallel #2831

Closed
AEgit opened this issue May 10, 2017 · 5 comments
Closed

Run "Abbreviate journal names" in parallel #2831

AEgit opened this issue May 10, 2017 · 5 comments

Comments

@AEgit
Copy link

AEgit commented May 10, 2017

JabRef 3.8.2
windows 10 10.0 amd64
Java 1.8.0_131

As far as I can tell, the "Abbreviate journal names" function in JabRef is currently run serially. While this is fine for smaller databases, it can pose a serious performance problem when dealing with large (>10,000 entries) databases. I propose to run this function in parallel - this should speed up things quite a lot, I guess.

@LinusDietz
Copy link
Member

Sounds like an good idea. Not having checked the code it should be easy to delegate this work to the JabrefExecutorService.

@tobiasdiez tobiasdiez changed the title Proposed enhancement: Run "Abbreviate journal names" in parallel Run "Abbreviate journal names" in parallel May 14, 2017
@tobiasdiez
Copy link
Member

This should be fixed in the latest development version thanks to a contribution by @Brainsucker92. Could you please check the build from http://builds.jabref.org/master/. Thanks!

@Siedlerchr
Copy link
Member

There is also a koppor issue related to that

@AEgit
Copy link
Author

AEgit commented Feb 16, 2018

I can confirm that the "Abbreviate journal names (ISO)" is run in parallel on:

JabRef 4.2-dev--snapshot--2018-02-15--master--36e4f0e56
Windows 10 10.0 amd64
Java 1.8.0_161

There appear to be some issues (?), though: Even when the abbreviation process is technically finished (i. e. all possible abbreviations have been carried out) as indicated by the status message, JabRef continues to use all the cores (at max. load) for quite some time afterwards. Eventually, JabRef will stop using all the cores and the CPU load drops again. Is this behaviour intended?

@Brainsucker92
Copy link
Contributor

Well, I can confirm the abbreviation process is definitely running parallel. I tested abbreviating 30.000 entries which takes about 90 seconds to process at nearly 100% load on my computer. After the abbreviation is done it drops back to normal load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants