Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DeclarationOrder in Eclipse and IntelliJ #2996

Closed
koppor opened this issue Jul 11, 2017 · 3 comments
Closed

Enable DeclarationOrder in Eclipse and IntelliJ #2996

koppor opened this issue Jul 11, 2017 · 3 comments
Assignees
Labels
type: code-quality Issues related to code or architecture decisions

Comments

@koppor
Copy link
Member

koppor commented Jul 11, 2017

DeclarationOrder should be set in the IntelliJ config - or disabled.

  1. Class (static) variables. First the public class variables, then the protected, then package level (no access modifier), and then the private.
  2. Instance variables. First the public class variables, then the protected, then package level (no access modifier), and then the private.
  3. Constructors
  4. Methods
@koppor koppor added the type: code-quality Issues related to code or architecture decisions label Jul 11, 2017
@koppor
Copy link
Member Author

koppor commented Jul 11, 2017

Refs #2765 (comment)
@snisnisniksonah

@tobiasdiez
Copy link
Member

tobiasdiez commented Jul 11, 2017

Same applies for the rule 'METHOD_DEF' has more than 1 empty lines before. [EmptyLineSeparator].

Moreover, the build should continue even when checkstyle errors are found (so that the unit tests are executed, which are more important then checkstyle issues)

@tobiasdiez
Copy link
Member

tobiasdiez commented Oct 26, 2017

I found a checkstyle IntellJ plugin, which imports a checkstyle configuration and changes the intellj code style accordingly. I also added a description of how to setup everything in the wiki. So this issue can be closed in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

No branches or pull requests

3 participants