Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems finding fulltext for IEEExplore #3966

Closed
krishnakumarg1984 opened this issue Apr 19, 2018 · 13 comments
Closed

Problems finding fulltext for IEEExplore #3966

krishnakumarg1984 opened this issue Apr 19, 2018 · 13 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs fetcher

Comments

@krishnakumarg1984
Copy link

krishnakumarg1984 commented Apr 19, 2018

Issues with IEEE full-text importer.

I have tested the latest master version from http://builds.jabref.org/master/JabRef--master--latest.jar on Windows 7 and the following problem is encountered.

JabRef version 4.2-dev on Windows 7 Enterprise (build 7601 service pack:1)

Steps to reproduce:

  1. Use Jabref on a network with full-text access to IEEExplore articles (such as a university's network)
  2. Start a new library with the following bibtex entry
@inproceedings{Morabito2017,
author = {Morabito, Bruno and Klein, Reinhardt and Findeisen, Rolf},
booktitle = {2017 American Control Conference (ACC)},
doi = {10.23919/ACC.2017.7963481},
isbn = {978-1-5090-5992-8},
month = {may},
pages = {3457--3462},
publisher = {IEEE},
title = {{Real time feasibility and performance of moving horizon estimation for Li-ion batteries based on first principles electrochemical models}},
url = {http://ieeexplore.ieee.org/document/7963481/},
year = {2017}
}
  1. Select this reference entry within Jabref and hit Alt + F7 or go to Quality -> Look up full text documents
  2. After a while, the following pop-up dialog box opens
    No full text document found for entry Morabito2017
  3. Expected behavior: Navigate to this same URL http://ieeexplore.ieee.org/document/7963481/. This works perfectly fine and full-text PDF can be manually downloaded. The auto downloader should have obtained this PDF and linked it to the citation entry.
@stefan-kolb stefan-kolb added fetcher status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Apr 20, 2018
@stefan-kolb
Copy link
Member

The test for open access articles such as https://ieeexplore.ieee.org/document/7421926/ work.
There should be no difference for the other articles as long as you really have access.
It is hard to debug for me as I don't have IEEE access at university. @JabRef/developers Anyone of you has access?

@Siedlerchr
Copy link
Member

I can reproduce this error. For me the IEEE fetcher tests fail when I am connected using university VPN.
The html page I get from the URL Downloader talks about missing cookie support. I will see if I can fix that

@stefan-kolb stefan-kolb added bug Confirmed bugs or reports that are very likely to be bugs and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Apr 20, 2018
@Siedlerchr
Copy link
Member

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you.

@krishnakumarg1984
Copy link
Author

No.... Please read the text very carefully...I have explicitly mentioned that I am using the latest developmental version. The problem still persists. Please reopen this issue

@stefan-kolb
Copy link
Member

We just merged a pull request fixing it.

@Siedlerchr
Copy link
Member

@krishnakumarg1984 Yes. I know. But I just merged the code into the master branch. The development build gets automatically updated and built by our CI servers whenever someone commits to the master branch. This usually takes a couple of minutes.
The version string contains the first part of the commit id. (help-> About)

@krishnakumarg1984
Copy link
Author

Ah. I am so sorry for not correctly interpreting what you said. I shall try the latest development build and report back. Sorry for the mild confusion in my last post

@krishnakumarg1984
Copy link
Author

krishnakumarg1984 commented Apr 20, 2018

@Siedlerchr @stefan-kolb We may have to reopen this issue.

I just tried with the latest build

JabRef 4.2-dev--snapshot--2018-04-20--master--8bbc40e13
Windows 7 6.1 x86
Java 1.8.0_161

from my university's network and same error pop-up message persists. Curiously the event log in Jabref is empty.

I wonder why #3968 says the problem is only with VPN access? I am currently physically on the campus library, on a Windows 7 machine hard-wired to the network with a LAN cable. Just to confirm that this is indeed a persisting bug, there is no issue with full-text access to this article from a standard browser pointed to the URL http://ieeexplore.ieee.org/document/7963481/

@tobiasdiez
Copy link
Member

I think @krishnakumarg1984 is right and the issue still persist. Just looking at the code,

// Try URL first -- will primarily work for entries from the old IEEE search
Optional<String> urlString = entry.getField(FieldName.URL);
if (urlString.isPresent()) {
// Is the URL a direct link to IEEE?
Matcher matcher = STAMP_PATTERN.matcher(urlString.get());
if (matcher.find()) {
// Found it
stampString = matcher.group(1);
}
}

with
private static final Pattern STAMP_PATTERN = Pattern.compile("(/stamp/stamp.jsp\\?t?p?=?&?arnumber=[0-9]+)");

is never going to match http://ieeexplore.ieee.org/document/7963481/.

@tobiasdiez tobiasdiez reopened this Apr 20, 2018
@Siedlerchr
Copy link
Member

Hmm that's odd. I will look into that again tomorrow

@Siedlerchr Siedlerchr mentioned this issue Apr 21, 2018
6 tasks
@Siedlerchr
Copy link
Member

@krishnakumarg1984 I just merged the fix which supports those the IEEE document urls you have like in your entry. And I also tested your entry with university access and worked for me. So I would like you to test this again

@krishnakumarg1984
Copy link
Author

krishnakumarg1984 commented Apr 21, 2018

@Siedlerchr thank you. I shall go to university to check this out. Will report back soon.

@krishnakumarg1984
Copy link
Author

krishnakumarg1984 commented Apr 21, 2018

Woohoo.... You guys are amazing.

I just tried the latest master-build from my university's network, and can confirm that this is now fixed . Was able to download the full-text of the bibtex entry for which the issue was opened.

Thank you for accepting and pro-actively working to fix this issue.

Version info of Jabref build used:

JabRef 4.2-dev--snapshot--2018-04-21--master--5c664e1d2
Windows 7 6.1 x86
Java 1.8.0_161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs fetcher
Projects
None yet
Development

No branches or pull requests

4 participants