Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrupt file field content causes UI problems. #402

Closed
matthiasgeiger opened this issue Nov 27, 2015 · 5 comments
Closed

Corrupt file field content causes UI problems. #402

matthiasgeiger opened this issue Nov 27, 2015 · 5 comments
Assignees
@matthiasgeiger
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Milestone
v3.3

Comments

@matthiasgeiger
Copy link
Member

As can be seen in #399 and #184 (comment) invalid file links produce crazy effects in the UI.

Potential Problems:

  • unescaped : in windows paths (as : is used as delimiter)
  • unescaped \
  • creative escapes as mentioned in Window content looks messed up #399: File = {:C$\backslash$:/Users/[myname]/Dropbox/Studies/Books/Analysis/[Hedy{}Attouch,{}Giuseppe{}Buttazzo,{}Gerard{_}MichailleVariationalBV.pdf:pdf}
  • invalid number of elements delimited by : ?
@matthiasgeiger matthiasgeiger added bug Confirmed bugs or reports that are very likely to be bugs testing labels Nov 27, 2015
@matthiasgeiger matthiasgeiger mentioned this issue Nov 27, 2015
Closed
@matthiasgeiger
Copy link
Member Author

related/affected #98

@koppor
Copy link
Member

koppor commented Nov 27, 2015

Maybe adding RemoveLatexCommands somewhere at the default preview is a quick fix? See
http://jabref.sourceforge.net/help/CustomExports.php

@stefan-kolb stefan-kolb added this to the v3.1 milestone Dec 9, 2015
@koppor koppor added the JabCon label Jan 8, 2016
@koppor koppor modified the milestones: v3.3, v3.1 Jan 8, 2016
@simonharrer
Copy link
Contributor

related? #557

@simonharrer
Copy link
Contributor

add tests to FileFieldTest @matthiasgeiger

@matthiasgeiger matthiasgeiger mentioned this issue Feb 29, 2016
Merged
4 tasks
@matthiasgeiger
Copy link
Member Author

Adding tests to FileFieldTest does not make sense - the problem here is a NPE which has been fixed in #893.

However, I might be useful if "wrong" file field contents are reported to the user somehow - but this is another issue ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthiasgeiger matthiasgeiger

Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Milestone
v3.3
Development

No branches or pull requests
4 participants
@simonharrer @matthiasgeiger @koppor @stefan-kolb