Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JabRef suddenly warns the file has changed on disk and requires review of changes (dropbox) #4143

Closed
johann-petrak opened this issue Jun 19, 2018 · 18 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs export / save

Comments

@johann-petrak
Copy link

This happened with version 4.3.1 on a Linux system: I added a few dozen new entries, saving the database after each new added entry, when suddenly the GUI told me that the database has changed on disk and forced me to review the changes, showing me the changes I have just made myself!
I am pretty sure no other process has actually updated the database on disk.
I know that there is nothing to review and I do not care if for some reasons the file modification date is not what jabref expects, I just want it to save and override the file on disk, but Jabref apparentlly does not allow that. This is very annoying.
So what I have to do is kill/abort jabref (losing the entry I was in the process of adding) and start it again.

@johann-petrak
Copy link
Author

In that situation, when the "Review changes" button is shown in the left pane of the GUI, clicking the "x" icon to close the program brings up a dialog "Please wait..." / "Waiting for save operation to finish" which is then shown forever.
The only way to exit the program is to kill it.

@Siedlerchr
Copy link
Member

DO you have autosave feature enabled? That could be causing issues in your case

@johann-petrak
Copy link
Author

If you mean the option "Autosave local libraries" in Options - File, then no, this was not checked.

However, I just noticed that there is a setting that may have made this a bit less frustrating: under "Library properties" there is the option "Refuse to save the library before external changes have been reviewed" which appears to have been set by default. Unsetting this will at least let me simply save the library even when JabRef incorrectly thinks for some reason it has been modified on the disk.

@johann-petrak
Copy link
Author

OK, turns out enabling the saving is not working as expected either: JabRef now allows the save button to get pressed, but after this the GUI becomes unresponsive and I still have to kill the program and start over and it turns out the latest version of the database was not saved.
This makes JabRef completely unusable for me I am going to downgrade to a previous version.

@Siedlerchr
Copy link
Member

HI, sorry to hear this.
Could you please out if the issue is resolved in the latest master?
https://builds.jabref.org/master
Please remember to make a backup of your library before trying-out this version.

@Siedlerchr Siedlerchr added status: waiting-for-feedback The submitter or other users need to provide more information about the issue os: linux labels Jun 21, 2018
@burrbull
Copy link
Contributor

I confirm an error. It is reproduced since version 4.1 to current master.

@bernhard-kleine
Copy link

This is nothing special to Linux, I have Windows 7 and the same issues which I have ignored because it is not critical. And yes, I have the autosave feature enabled.

@ilippert
Copy link
Contributor

ilippert commented Jul 5, 2018

I experience the same problem at JabRef 5.0-dev--snapshot--2018-07-02--master--aed7712bc
Linux 4.17.3-200.fc28.x86_64 amd64
Java 1.8.0_172

@bernhard-kleine
Copy link

bernhard-kleine commented Jul 14, 2018

With the snapshot from yesterday, the problem is still there.

@bernhard-kleine
Copy link

I am sorry to bring this up again. There was a reaction to the waiting for feedback already some time ago. At least remove the label "waiting for feedback", please.

@wujastyk
Copy link

wujastyk commented Aug 28, 2018

JabRef 4.3.1
Linux 4.15.0-33-generic amd64
Java 1.8.0_181

JabRef 5.0-dev--snapshot--2018-08-28--master--9365d9cb1
Linux 4.15.0-33-generic amd64
Java 1.8.0_181

I confirm the error in 4.3.1 and in the current development snapshot. It's very annoying when one is trying to work seriously and sometimes leads to data loss.

Screenshot from development snapshot:

screenshot from 2018-08-26 11-36-12

Screenshots from 4.3.1:

screenshot from 2018-08-26 12-31-06
screenshot from 2018-08-12 22-29-07

screenshot from 2018-08-12 22-00-55

@Siedlerchr
Copy link
Member

As you seem to encounter this more often, could you please add some information and or upload your preferences? (you can export them).
The problem is that this is hard to reproduce and therefore to find the root cause

@wujastyk
Copy link

wujastyk commented Aug 28, 2018

I have no idea what activities precede this "file updated externally" message. I have tried to think of trigger situations, and I can't. I am editing a record: that's a common feature. Otherwise <shrug>.

I do have Dropbox running on all my machines. So Dropbox is periodically copying my bib files to the cloud. I've often wondered if that's the issue. It shouldn't be, but....

Here are my preferences (I have in the past had "autosave" turned on; I just turned it off today):

jabref431-preferences.txt

@Siedlerchr
Copy link
Member

Siedlerchr commented Aug 28, 2018

Dropbox could indeed be an issue. If I remember correctly, saving causes JabRef to make a temporary copy of the db and then replacing the original file. So it could be that during that copying process dropbox kicks in with synchronizing the changes before the copy finished which would explain the review changes messages

Edit// With a NextCloud sync folder I can reproduce the issue

The save logic is still a relict of old times when saving was unreliable. As far as I know @stefan-kolb already took a look at that. Maybe he can shed some light on that issue here

@wujastyk
Copy link

wujastyk commented Aug 28, 2018 via email

@Siedlerchr Siedlerchr changed the title JabRef suddenly warns the file has changed on disk and requires review of changes JabRef suddenly warns the file has changed on disk and requires review of changes (dropbox) Aug 28, 2018
@Siedlerchr Siedlerchr removed os: linux status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Aug 28, 2018
@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs export / save labels Aug 28, 2018
@tobiasdiez
Copy link
Member

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

@johann-petrak
Copy link
Author

I regularly update to the latest development version and I have not seen this happening for a while now.
Sorry, I since this was an intermittent problem I cannot tell if it actually was fixed or I was just lucky and if it was fixed, since when ;)

@ilippert
Copy link
Contributor

yes, still/again present in current snap version - I am reporting this as a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs export / save
Projects
Archived in project
Development

No branches or pull requests

8 participants