Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality check on the journaltitle field not working proberly #5562

Closed
bernhard-kleine opened this issue Nov 3, 2019 · 3 comments
Closed

Comments

@bernhard-kleine
Copy link

JabRef 5.0.0-dev--2019-11-03----921f44283
Windows 7 6.1 amd64
Java 12.0.2

Steps to reproduce the behavior:

  1. type e.g. European Journal of Biochemistry into the journaltitle field
  2. by the button to the right of that field change the text to the abbreviated Journaltitle.
  3. The correct Eur. J. Biochem. gets the "error" orange triangle.
  4. If you press the button again the Eur J Biochem shows which has also the orange triangle.

As clicking the triangle does not show any message at all, I wonder why the triangle and whether the meaning of it is totally superfluous.

grafik

Log File
Paste an excerpt of your log file here
@jorgman1
Copy link

Hovering over the triangle shows: "abbreviation detected". Which is the same message that one gets in the integrity check.

I suppose it is better practice to have the complete journal name in the database and abbreviate it uppon using it. That way, the database can be transfered to someone without abbreviation list.

@Hollyqqqqq
Copy link
Contributor

Hi, I was going to try fixing this bug. But I found it a little comfused.

I think maybe it is not a bug. The orange triangle is not "error" but "warning". I think it is reasonable to have this "warning triangle" if this message occurs when running "Check integrity". In other words, if this "warning triangle" shouldn't occur, then "Check integrity" shouldn't occur this message, either.
image
image
Does this issue mean that, in expected result, "abbreviation detected" message as well as the "warning triangle" shouldn't occur? Or just "warning triangle" shouldn't occur? Or maybe it is not a bug as I mentioned above?

If there is any misunderstanding, please point it out. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

  • If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
  • Provide further steps or information on how to reproduce this issue.
  • Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
  • If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants