Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inability to enter data in Optional Fields #6901

Closed
rs-aesi opened this issue Sep 10, 2020 · 7 comments
Closed

Inability to enter data in Optional Fields #6901

rs-aesi opened this issue Sep 10, 2020 · 7 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@rs-aesi
Copy link

rs-aesi commented Sep 10, 2020

Running the 5.2-linux-portable build of 2020-09-09. The optional fields tab has 2 columns on the left for data entry and a preview of the entire entry on the right. However, text cannot be entered in the right column and that whole window cannot be expanded to allow data entry.

The attached screen shot illustrates the situation. Notice in the right side window the volume number (8) at the end of the text. That number is not visible in the volume entry field on the right half of the display.

I kept trying to enter the volume and expand that window, but was unsuccessful. I noticed the string of volume numbers in the right side window and hit the delete key until only a single '8' was present.

This situation was in a previous release and fixed. Please fix again.

@rs-aesi
Copy link
Author

rs-aesi commented Sep 11, 2020

Update: this same problem exists with the stable 5.1 release (linux-portable-5.1).

@Siedlerchr
Copy link
Member

Yeah, it's a problem if the entry preview is shown as part of the entry editor.
You can only expand the colum if you move the preview to the right or you can tick the options show preview as own tab.

The code for calculating the column constraints and witths in the "compressed" mode is here:

if (compressed) {
rows = (int) Math.ceil((double) fields.size() / 2);
addColumn(gridPane, 0, labels.subList(0, rows));
addColumn(gridPane, 3, labels.subList(rows, labels.size()));
addColumn(gridPane, 1, editors.values().stream().map(FieldEditorFX::getNode).limit(rows));
addColumn(gridPane, 4, editors.values().stream().map(FieldEditorFX::getNode).skip(rows));
gridPane.getColumnConstraints().addAll(columnDoNotContract, columnExpand, new ColumnConstraints(10),
columnDoNotContract, columnExpand);
setCompressedRowLayout(gridPane, rows);

@rs-aesi
Copy link
Author

rs-aesi commented Sep 12, 2020 via email

@Siedlerchr
Copy link
Member

You can drag the preview a bit more to the right at that line
Bildschirmfoto 2020-09-12 um 19 08 21

@rs-aesi Unfortunately, it's not possible to change the tab order.
However, you can disable the Related Articles Tab and the Latex Citations tab under Options -> Entry editor.
The tab latex citations allows you to show where in a LaTeX document you have used your current reference.

Regarding the emacs keybindings. Well it might be an issue for you, but apparently many others are happy with the defaults. And the issue is still open. Maybe you can find someone who is interested in re-implementing it.

@Siedlerchr Siedlerchr added ui bug Confirmed bugs or reports that are very likely to be bugs labels Oct 3, 2020
@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Oct 4, 2020
@JohanDelValleV
Copy link
Contributor

Is this issue still open? I'm looking for OP projects to contribute @Siedlerchr

@Siedlerchr
Copy link
Member

@JohanDelValleV Thanks your your interest! Yes, the issue is still available. And it would be really nice to have this issue fixed.
For getting started follow our contribution guide.
Code wise the layout is calculated by the code I posted above.

If you need any help, ask here or in our gitter channel

https://github.com/JabRef/jabref/blob/master/CONTRIBUTING.md

@Siedlerchr
Copy link
Member

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/main and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

Fixed by #8232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Archived in project
Archived in project
Development

No branches or pull requests

5 participants