Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate user input of custom theme paths and provide visual feedback #7323

Open
docrjp opened this issue Jan 10, 2021 · 4 comments
Open

Validate user input of custom theme paths and provide visual feedback #7323

docrjp opened this issue Jan 10, 2021 · 4 comments

Comments

@docrjp
Copy link
Contributor

docrjp commented Jan 10, 2021

Present to the user hints that the custom theme path is not valid, or cannot be found. The feedback should be bound to the input such that it is immediate (i.e. a hint next to the textbox). That is, it should not necessary to apply the preference changes to get an error message.

This is a follow up on #7177 and in response to a discussion in review of the related pull request: #7292 (comment)

@docrjp docrjp changed the title Validate user input of custom theme paths and provide feedback Validate user input of custom theme paths and provide visual feedback Jan 10, 2021
@Siedlerchr
Copy link
Member

An example is for example the SharedDatbaseLogin dialog, it shows how those Icon based Validators work and can be connected to input.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

  • If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
  • Provide further steps or information on how to reproduce this issue.
  • Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
  • If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

@koppor
Copy link
Member

koppor commented Aug 2, 2021

This scheduled be fixed with #7335.

@Siedlerchr
Copy link
Member

@calixtus If I'm not mistaken this issue is fixed now?

@koppor koppor moved this to Low priority in Features & Enhancements Nov 7, 2022
@github-project-automation github-project-automation bot moved this to Normal priority in Prioritization Nov 13, 2024
@calixtus calixtus moved this from Normal priority to Low priority in Prioritization Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Low priority
Development

No branches or pull requests

3 participants