From 21e69c7d17e468108c1d0ca8000ada1ca0598908 Mon Sep 17 00:00:00 2001 From: Lucas Freund <127773292+Luggas4you@users.noreply.github.com> Date: Sun, 17 Sep 2023 17:26:10 +0200 Subject: [PATCH 1/4] Replace fetcherName with Identifier-based Web Search --- .../org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java b/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java index d4a199a2948..393e09c2f41 100644 --- a/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java +++ b/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java @@ -154,7 +154,7 @@ public void search() { if (CompositeIdFetcher.containsValidId(query)) { CompositeIdFetcher compositeIdFetcher = new CompositeIdFetcher(preferencesService.getImportFormatPreferences()); parserResultCallable = () -> new ParserResult(OptionalUtil.toList(compositeIdFetcher.performSearchById(query))); - fetcherName = compositeIdFetcher.getName(); + fetcherName = "Identifier-based Web Search"; } final String finalFetcherName = fetcherName; From 0eb73b0d8f31d759d2385af85e3c2013ac6ff625 Mon Sep 17 00:00:00 2001 From: Lucas Freund <127773292+Luggas4you@users.noreply.github.com> Date: Thu, 21 Sep 2023 07:59:34 +0200 Subject: [PATCH 2/4] Add l10n --- src/main/resources/l10n/JabRef_en.properties | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties index 7abf562ad2c..59f47434f67 100644 --- a/src/main/resources/l10n/JabRef_en.properties +++ b/src/main/resources/l10n/JabRef_en.properties @@ -2593,3 +2593,4 @@ Citation\ relations=Citation relations Show\ articles\ related\ by\ citation=Show articles related by citation Error\ while\ fetching\ citing\ entries\:\ %0=Error while fetching citing entries: %0 Jump\ to\ entry\ in\ database=Jump to entry in database +Identifier-based\ Web\ Search=Identifier-based Web Search From a50068d82d3d212c9beb647f724d50f52af777e8 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Fri, 22 Sep 2023 10:55:23 +0200 Subject: [PATCH 3/4] Add Localization.lang(...) --- .../org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java b/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java index 393e09c2f41..5634e4e7450 100644 --- a/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java +++ b/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java @@ -154,7 +154,7 @@ public void search() { if (CompositeIdFetcher.containsValidId(query)) { CompositeIdFetcher compositeIdFetcher = new CompositeIdFetcher(preferencesService.getImportFormatPreferences()); parserResultCallable = () -> new ParserResult(OptionalUtil.toList(compositeIdFetcher.performSearchById(query))); - fetcherName = "Identifier-based Web Search"; + fetcherName = Localization.lang("Identifier-based Web Search"); } final String finalFetcherName = fetcherName; From e3d48f4859c53645fd0f3d71c67c9713d7eeb70b Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Fri, 22 Sep 2023 10:57:19 +0200 Subject: [PATCH 4/4] Add CHANGELOG.md entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d0c69923ae9..68032150277 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv ### Changed - The export formats `listrefs`, `tablerefs`, `tablerefsabsbib`, now use the ISO date format in the footer [#10383](https://github.com/JabRef/jabref/pull/10383). +- When searching for an identifier in the "Web search", the title of the search window is now "Identifier-based Web Search". [#10391](https://github.com/JabRef/jabref/pull/10391) ### Fixed