Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable search tooltip #4971

Closed
wants to merge 2 commits into from
Closed

Disable search tooltip #4971

wants to merge 2 commits into from

Conversation

davidemdot
Copy link
Member

Now the extended help in the search field, showed as a tooltip, has been removed. It solves #3599.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

tobiasdiez
tobiasdiez approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calixtus calixtus mentioned this pull request May 17, 2019
Merged
6 tasks
@davidemdot
Copy link
Member Author

I will close this PR because there is a better solution in #4975.

@davidemdot davidemdot closed this May 18, 2019
tobiasdiez pushed a commit that referenced this pull request May 18, 2019
@calixtus @tobiasdiez
Extended Hints - Alternative to #4971 (#4975)
accdef3 
* Added Preference "Show helpful Tooltips" to GeneralTab and
a check for in the SearchBar

* l10n

* changelog

* Reword Identifier and Label

* Refactor Hint Message in GlobalSearchBar

* Added switchable visibility of hint for GlobalSearchBar

* Add switchable visibility of remote connection text

* Add Issue Number in Changelog

* Fixes Typo

* Fix Undone Change to updateAfterPreferenceChanges()
Siedlerchr added a commit that referenced this pull request May 19, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into convertSearchWorker
32925d8 
* upstream/master:
  Resize different fonts changing entry type (#4980)
  Extended Hints - Alternative to #4971 (#4975)
  Fix command line help text (#4979)

# Conflicts:
#	src/main/java/org/jabref/gui/search/GlobalSearchBar.java
Siedlerchr added a commit that referenced this pull request May 26, 2019
@Siedlerchr
Merge branch 'ieeFix' of github.com:JabRef/jabref into ieeFix
62553de 
* 'ieeFix' of github.com:JabRef/jabref:
  Fix the 'Attach file' dialog for starting on the user's main directory (#4996)
  Readme TOC (#4986)
  Fix icon size - the second (#4993)
  Fix background color of dialogs in dark mode (#4994)
  NPE-fix for Preferences/Ext-Prog/Settings for X/Browse  (#4983)
  Bump richtextfx from 0.10.0 to 0.10.1 (#4989)
  Bump tika-core from 1.20 to 1.21 (#4984)
  Resize different fonts changing entry type (#4980)
  Extended Hints - Alternative to #4971 (#4975)
  Fix command line help text (#4979)
@davidemdot davidemdot deleted the disable-search-tooltip branch July 27, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidemdot @tobiasdiez